From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:54232)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1RcxKQ-0002kv-TI
	for qemu-devel@nongnu.org; Tue, 20 Dec 2011 05:53:55 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1RcxKL-0001ye-6q
	for qemu-devel@nongnu.org; Tue, 20 Dec 2011 05:53:50 -0500
Received: from mx1.redhat.com ([209.132.183.28]:43688)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1RcxKK-0001yY-SV
	for qemu-devel@nongnu.org; Tue, 20 Dec 2011 05:53:45 -0500
Message-ID: <4EF06934.7040107@redhat.com>
Date: Tue, 20 Dec 2011 12:53:40 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1323982273-13623-1-git-send-email-jordan.l.justen@intel.com>
	<CAFe8ug8LJFyYzYMhTk5T+3=EOdeD5eFH7JF-nrcPF795iz_12g@mail.gmail.com>
	<4EEDBAA2.7000200@redhat.com>
	<CAFe8ug-Hrz++TTjK1H=WyURNKDSy4uJCefWLTY+7BnwNFXzGfQ@mail.gmail.com>
In-Reply-To: <CAFe8ug-Hrz++TTjK1H=WyURNKDSy4uJCefWLTY+7BnwNFXzGfQ@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v9 0/3] PC system flash support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jordan Justen <jljusten@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On 12/19/2011 08:27 PM, Jordan Justen wrote:
> On Sun, Dec 18, 2011 at 02:04, Avi Kivity <avi@redhat.com> wrote:
> > On 12/15/2011 11:02 PM, Jordan Justen wrote:
> >> I verified that 'info mtree' and 'info qdev' are equivalent for pc-1.0
> >> when using master and with my patches.
> >>
> >> However, I did discover that v1.0 seems to differ from master for this
> >> same test.
> >>
> >
> > That's are fine; pre-memory-API devices don't show up in info mtree.
> >
> >> @@ -218,7 +221,7 @@
> >>      dev-prop: data_iobase = 0x511
> >>      irq 0
> >>      mmio ffffffffffffffff/0000000000000002
> >> -    mmio ffffffffffffffff/0000000000000002
> >> +    mmio ffffffffffffffff/0000000000000001
> >>
> >
> > This one isn't nice.  Doesn't affect pc though.
>
> Thanks Avi.  Does this patch series now address your concerns about
> qtree/mtree and pc-1.0 with regards to the x86 flash feature?
>

It's hard to review, since you move a large function and edit it in the
same patch.  Usually we separate this into two patches so the changes
are visible.

The test however indicates that it's probably fine.

-- 
error compiling committee.c: too many arguments to function