From: Avi Kivity <avi@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] hw/integratorcp: Simplify flash remap code, fix sense of REMAP bit
Date: Tue, 20 Dec 2011 13:00:19 +0200 [thread overview]
Message-ID: <4EF06AC3.4050004@redhat.com> (raw)
In-Reply-To: <1324313143-28629-1-git-send-email-peter.maydell@linaro.org>
On 12/19/2011 06:45 PM, Peter Maydell wrote:
> Use the new memory mutator API to simplify the flash remap code;
> this allows us to drop the flash_mapped flag.
>
> This patch also fixes the sense of the REMAP bit, which was
> reversed.
>
I'm surprised the word "also" doesn't cause the maintainers' scripts to
auto-reject the patch. It makes the patch hard to review, and also
makes cherry picking for updating stable releases harder.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-12-20 11:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-19 16:45 [Qemu-devel] [PATCH] hw/integratorcp: Simplify flash remap code, fix sense of REMAP bit Peter Maydell
2011-12-20 11:00 ` Avi Kivity [this message]
2011-12-20 15:51 ` Peter Maydell
2011-12-20 15:57 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EF06AC3.4050004@redhat.com \
--to=avi@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).