From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:46529) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RcxQv-0006um-2W for qemu-devel@nongnu.org; Tue, 20 Dec 2011 06:00:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RcxQl-0003SD-JB for qemu-devel@nongnu.org; Tue, 20 Dec 2011 06:00:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45198) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RcxQl-0003S3-5v for qemu-devel@nongnu.org; Tue, 20 Dec 2011 06:00:23 -0500 Message-ID: <4EF06AC3.4050004@redhat.com> Date: Tue, 20 Dec 2011 13:00:19 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1324313143-28629-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1324313143-28629-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] hw/integratorcp: Simplify flash remap code, fix sense of REMAP bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org, patches@linaro.org On 12/19/2011 06:45 PM, Peter Maydell wrote: > Use the new memory mutator API to simplify the flash remap code; > this allows us to drop the flash_mapped flag. > > This patch also fixes the sense of the REMAP bit, which was > reversed. > I'm surprised the word "also" doesn't cause the maintainers' scripts to auto-reject the patch. It makes the patch hard to review, and also makes cherry picking for updating stable releases harder. -- error compiling committee.c: too many arguments to function