From: Paolo Bonzini <pbonzini@redhat.com>
Cc: Michael Roth <mdroth@linux.vnet.ibm.com>,
qemu-devel <qemu-devel@nongnu.org>,
Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 01/10] qapi: add Visitor interfaces for uint*_t and int*_t
Date: Tue, 20 Dec 2011 13:00:26 +0100 [thread overview]
Message-ID: <4EF078DA.2090302@redhat.com> (raw)
In-Reply-To: <4EF074E3.1090505@redhat.com>
On 12/20/2011 12:43 PM, Paolo Bonzini wrote:
>
> 1) You can still add a vtable to QEMUFile for "visit_type_int*" and
> "visit_type_uint*". But this vtable doesn't need start/end callbacks.
Here I meant something simple like:
void (*visit_type_int16) (QEMUFile *f, int16_t *x);
that is really the same as qemu_{get,put}_be16s and friends.
It may even be not a vtable, but a function that dispatches based on the
existing get_buffer/put_buffer callbacks: note that one of them is
always NULL. Which also means that the is_write field is superfluous.
So much cleanup to do. :(
Paolo
next prev parent reply other threads:[~2011-12-20 12:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-27 17:06 [Qemu-devel] [PATCH v2 00/10] do savevm/migration save/load via Visitor interface Michael Roth
2011-10-27 17:06 ` [Qemu-devel] [PATCH v2 01/10] qapi: add Visitor interfaces for uint*_t and int*_t Michael Roth
2011-12-20 11:12 ` Paolo Bonzini
2011-12-20 11:43 ` Paolo Bonzini
2011-12-20 12:00 ` Paolo Bonzini [this message]
2011-12-20 13:50 ` Anthony Liguori
2011-12-20 14:30 ` Paolo Bonzini
2011-12-20 20:22 ` Michael Roth
2011-12-21 12:29 ` Paolo Bonzini
2011-12-20 20:56 ` Anthony Liguori
2011-12-21 12:35 ` Paolo Bonzini
2011-12-21 14:45 ` Anthony Liguori
2011-12-21 15:39 ` Paolo Bonzini
2011-12-21 16:24 ` Anthony Liguori
2011-12-21 16:52 ` Paolo Bonzini
2011-10-27 17:06 ` [Qemu-devel] [PATCH v2 02/10] qapi: add QemuFileOutputVisitor Michael Roth
2011-10-27 17:06 ` [Qemu-devel] [PATCH v2 03/10] qapi: add QemuFileInputVisitor Michael Roth
2011-10-27 17:06 ` [Qemu-devel] [PATCH v2 04/10] savevm: move QEMUFile interfaces into qemu-file.c Michael Roth
2011-10-27 17:06 ` [Qemu-devel] [PATCH v2 05/10] qapi: test cases for QEMUFile input/output visitors Michael Roth
2011-10-27 17:06 ` [Qemu-devel] [PATCH v2 06/10] qemu-file: add QEMUFile<->visitor lookup routines Michael Roth
2011-10-27 17:06 ` [Qemu-devel] [PATCH v2 07/10] trace: qemu_(put|get)_(byte|buffer) events Michael Roth
2011-10-27 17:06 ` [Qemu-devel] [PATCH v2 08/10] trace: add trace statements for visitor interface Michael Roth
2011-10-27 17:06 ` [Qemu-devel] [PATCH v2 09/10] qapi: add trace statements to qapi-visit-core.c Michael Roth
2011-10-27 17:06 ` [Qemu-devel] [PATCH v2 10/10] vmstate: use visitors Michael Roth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EF078DA.2090302@redhat.com \
--to=pbonzini@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).