From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:50808) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rd0Uf-0001Ff-4A for qemu-devel@nongnu.org; Tue, 20 Dec 2011 09:16:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rd0Ue-0006Ci-3E for qemu-devel@nongnu.org; Tue, 20 Dec 2011 09:16:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47136) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rd0Ud-0006CZ-RM for qemu-devel@nongnu.org; Tue, 20 Dec 2011 09:16:36 -0500 Message-ID: <4EF098BF.7080206@redhat.com> Date: Tue, 20 Dec 2011 16:16:31 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1324389914-12246-1-git-send-email-avi@redhat.com> <1324389914-12246-3-git-send-email-avi@redhat.com> <4EF09720.9080505@codemonkey.ws> In-Reply-To: <4EF09720.9080505@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] vmstate, memory: decouple vmstate from memory API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, quintela@redhat.com On 12/20/2011 04:09 PM, Anthony Liguori wrote: > On 12/20/2011 08:05 AM, Avi Kivity wrote: >> Currently creating a memory region automatically registers it for >> live migration. This differs from other state (which is enumerated >> in a VMStateDescription structure) and ties the live migration code >> into the memory core. >> >> Decouple the two by introducing a separate API, vmstate_register_ram(), >> for registering a RAM block for migration. Currently the same >> implementation is reused, but later it can be moved into a separate >> list, >> and registrations can be moved to VMStateDescription blocks. > > Makes a lot of sense to me. Did you write a script to do the conversion? No, manual conversion. Had to add vmstate_unregister_ram() in the few places that had destructors. -- error compiling committee.c: too many arguments to function