From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:40285) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rd2Vw-0002lA-A2 for qemu-devel@nongnu.org; Tue, 20 Dec 2011 11:26:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rd2Vu-0008UC-LL for qemu-devel@nongnu.org; Tue, 20 Dec 2011 11:26:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:31624) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rd2Vu-0008U8-Ej for qemu-devel@nongnu.org; Tue, 20 Dec 2011 11:26:02 -0500 Message-ID: <4EF0B711.6070909@redhat.com> Date: Tue, 20 Dec 2011 09:25:53 -0700 From: Eric Blake MIME-Version: 1.0 References: <4EF04D58.3030900@cn.fujitsu.com> <4EF0522D.4040906@cn.fujitsu.com> In-Reply-To: <4EF0522D.4040906@cn.fujitsu.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig2344CAE99AA209F8ECE106E7" Subject: Re: [Qemu-devel] [RFC][PATCH 8/8 v3] introduce a new monitor command 'dump' to dump guest's memory List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wen Congyang Cc: Jan Kiszka , HATAYAMA Daisuke , Dave Anderson , qemu-devel This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig2344CAE99AA209F8ECE106E7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 12/20/2011 02:15 AM, Wen Congyang wrote: > Signed-off-by: Wen Congyang > --- > Makefile.target | 8 +- > dump.c | 452 +++++++++++++++++++++++++++++++++++++++++++++++= ++++++++ > dump.h | 4 + > hmp-commands.hx | 16 ++ > monitor.c | 3 + > qmp-commands.hx | 24 +++ > 6 files changed, 503 insertions(+), 4 deletions(-) > create mode 100644 dump.c >=20 > +++ b/qmp-commands.hx > @@ -469,6 +469,30 @@ Notes: > EQMP > =20 > { > + .name =3D "dump", > + .args_type =3D "file:s", > + .params =3D "file", > + .help =3D "dump to file", > + .user_print =3D monitor_user_noop, > + .mhandler.cmd_new =3D do_dump, > + }, =46rom a libvirt perspective, we would like the option to be able to pass= in an already-open fd rather than just a file name. This is possible if the 'file' argument is required to start with '/' for an absolute path, vs. 'file:name' for an fd previously passed in via the getfd monitor command. Also, does this command block? It sounds like it is long-running, which means it probably needs to be asynchronous, as well as issue an event upon completion, so that other monitor commands can be issued in the meantime. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig2344CAE99AA209F8ECE106E7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJO8LcRAAoJEKeha0olJ0Nq6zwH/jdiwLKCkdHRtTxbPDFDVMIJ IiOED0qh5kYscHI9gRjEOHjza/FY//FdU/jen3GL9zIzXxeegezb19RcNNwEx1gR gP1GNxeYXWAexmCxrINlSsukTEe9Vwl/82Pdsn6uCAe0bmWGRxygns6WAMsRPFzM MZ9cG2lqb2Mh2qtMd4dZlMnsGHz745icbwRrFeWridlTT4UUHRW9xGBkhG2s3d5/ q+pwDH8RzQwVLjEOJCfK+UyOqcOEJpholzehZ+SwFev26NJDyponfVF7Tnmmm6Nh N99Oi1nUsW3tA9k8Ff9mstRb3BSKJybQJgfw2Zr/QqPHu0efum/314V9dssZqK4= =a9Dr -----END PGP SIGNATURE----- --------------enig2344CAE99AA209F8ECE106E7--