From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:35063) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rd3KG-0001fb-H8 for qemu-devel@nongnu.org; Tue, 20 Dec 2011 12:18:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rd3KC-0004rz-4S for qemu-devel@nongnu.org; Tue, 20 Dec 2011 12:18:04 -0500 Received: from e2.ny.us.ibm.com ([32.97.182.142]:54806) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rd3KB-0004r1-MS for qemu-devel@nongnu.org; Tue, 20 Dec 2011 12:17:59 -0500 Received: from /spool/local by e2.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 20 Dec 2011 12:17:57 -0500 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay06.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id pBKHDKrf2072732 for ; Tue, 20 Dec 2011 12:13:20 -0500 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id pBKHDJta031979 for ; Tue, 20 Dec 2011 15:13:20 -0200 Message-ID: <4EF0C22A.6020306@linux.vnet.ibm.com> Date: Tue, 20 Dec 2011 12:13:14 -0500 From: Corey Bryant MIME-Version: 1.0 References: <1324300318-3419-1-git-send-email-coreyb@linux.vnet.ibm.com> <1324300318-3419-5-git-send-email-coreyb@linux.vnet.ibm.com> <4EEF922B.4050802@us.ibm.com> <4EEFC0DB.3050904@linux.vnet.ibm.com> <4EEFC59C.3090609@codemonkey.ws> In-Reply-To: <4EEFC59C.3090609@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v6 4/4] Add support for net bridge List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Anthony Liguori , rmarwah@linux.vnet.ibm.com, qemu-devel@nongnu.org On 12/19/2011 06:15 PM, Anthony Liguori wrote: > On 12/19/2011 04:55 PM, Corey Bryant wrote: >> >> >>>> diff --git a/net.c b/net.c >>>> index f7bebf8..9296224 100644 >>>> --- a/net.c >>>> +++ b/net.c >>>> @@ -952,6 +952,14 @@ static const struct { >>>> .type = QEMU_OPT_STRING, >>>> .help = "script to shut down the interface", >>>> }, { >>>> + .name = "br", >>>> + .type = QEMU_OPT_STRING, >>>> + .help = "bridge name", >>>> + }, { >>> >>> I don't think passing br= makes a whole of sense for -net tap. I think >>> it would make more sense to make sure that helper could take a shell >>> string so you could do: >>> >>> -netdev tap,helper="/usr/libexec/qemu-bridge-helper --br=br0" >>> >>> Regards, >>> >>> Anthony Liguori >>> >> >> Ok but do you think the -net bridge options should remain as-is? It >> seems like >> execution of the helper should be consistent. Here are the current >> options for >> -net bridge: >> >> -net bridge,helper=/usr/local/libexec/qemu-bridge-helper,br=br0 > > Yes. -net bridge is syntactic sugar for -net tap with specific knowledge > of the qemu-bridge-helper. > > If someone wrote a 'qemu-openvswitch-helper' then you could imagine a > '-net openvswitch' option that passed a bunch of openvswitch specific > arguments. > > Regards, > > Anthony Liguori > >> > > It seems like the helper should accept the following arguments: --vnet-hdr --br= --fd= (It already accept these, but the --br= and --fd= syntax aren't required at the moment.) Then QEMU would only allow the following to be specified for -netdev tap: -netdev tap,helper="/usr/libexec/qemu-bridge-helper" or -netdev tap,helper="/usr/libexec/qemu-bridge-helper --br=bridge" and would ignore or reject --vnet-hdr and --fd=. --vnet-hdr and --fd= would always be specified internally when the helper is exec'd. -- Regards, Corey