From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47403) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RdMhQ-0000OZ-Mk for qemu-devel@nongnu.org; Wed, 21 Dec 2011 08:59:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RdMhL-0001I2-1r for qemu-devel@nongnu.org; Wed, 21 Dec 2011 08:59:16 -0500 Received: from mail-gx0-f173.google.com ([209.85.161.173]:45605) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RdMhK-0001Hy-VX for qemu-devel@nongnu.org; Wed, 21 Dec 2011 08:59:11 -0500 Received: by ggnk1 with SMTP id k1so6397680ggn.4 for ; Wed, 21 Dec 2011 05:59:10 -0800 (PST) Message-ID: <4EF1E62A.5090508@codemonkey.ws> Date: Wed, 21 Dec 2011 07:59:06 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1324474477-22267-1-git-send-email-avi@redhat.com> In-Reply-To: <1324474477-22267-1-git-send-email-avi@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/8] Convert live migration to memory API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: qemu-devel@nongnu.org, quintela@redhat.com On 12/21/2011 07:34 AM, Avi Kivity wrote: > These patches, on top of "vmstate, memory: decouple vmstate from memory API", > convert live migration to use the memory API. > > Patch 4 is an ABI change, please review carefully. Using ram_addr_t for migration was badly, badly broken. I think it's been long enough that we can safely remove that logic. Other than my request for a better commit message, this whole series: Reviewed-by: Anthony Liguori Regards, Anthony Liguori > > Avi Kivity (8): > Store MemoryRegion in RAMBlock > Switch ram_save to the memory API > Sort RAMBlocks by ID for migration, not by ram_addr > Remove support for version 3 ram_load > Convert ram_load() to the memory API > memory: obsolete cpu_physical_memory_[gs]et_dirty_tracking() > xen: convert framebuffer dirty tracking to memory API > memory: obsolete more dirty memory related functions > > arch_init.c | 71 +++++++++++++++++++----------------------------------- > cpu-all.h | 54 +----------------------------------------- > exec-obsolete.h | 51 +++++++++++++++++++++++++++++++++++++++ > exec.c | 11 +------- > memory.c | 2 + > xen-all.c | 5 +-- > 6 files changed, 82 insertions(+), 112 deletions(-) >