From: Anthony Liguori <anthony@codemonkey.ws>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Regression: cold plug with device_add fails assertion
Date: Wed, 21 Dec 2011 08:08:10 -0600 [thread overview]
Message-ID: <4EF1E84A.2060402@codemonkey.ws> (raw)
In-Reply-To: <m3d3bii3yp.fsf@blackfin.pond.sub.org>
On 12/21/2011 05:01 AM, Markus Armbruster wrote:
> Test case:
>
> $ echo -e 'device_add usb-mouse\nq' | qemu-system-x86_64 -vnc :0 -monitor stdio -usb
>
> Works in v1.0, doesn't work in master's commit ab0115e1:
>
> qemu-system-x86_64: /work/armbru/qemu/hw/qdev.c:97: qdev_create_from_info: Assertion `bus->allow_hotplug' failed.
>
> Same for virtio-blk-pci, so it's not specific to USB.
Yes, see:
http://mid.gmane.org/1324334380-25278-1-git-send-email-aliguori@us.ibm.com
Which is in the latest qemu.git.
I also added a test to qemu-test to catch this.
Regards,
Anthony Liguori
>
> git-bisect:
>
> 8eb02831af6c5534d8712cb8db1104852cac26e9 is the first bad commit
> commit 8eb02831af6c5534d8712cb8db1104852cac26e9
> Author: Anthony Liguori<aliguori@us.ibm.com>
> Date: Mon Dec 12 14:29:37 2011 -0600
>
> dev: add an anonymous peripheral container
>
> Signed-off-by: Anthony Liguori<aliguori@us.ibm.com>
>
next prev parent reply other threads:[~2011-12-21 14:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-21 11:01 [Qemu-devel] Regression: cold plug with device_add fails assertion Markus Armbruster
2011-12-21 14:08 ` Anthony Liguori [this message]
2012-01-02 12:11 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EF1E84A.2060402@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).