* [Qemu-devel] Regression: cold plug with device_add fails assertion
@ 2011-12-21 11:01 Markus Armbruster
2011-12-21 14:08 ` Anthony Liguori
0 siblings, 1 reply; 3+ messages in thread
From: Markus Armbruster @ 2011-12-21 11:01 UTC (permalink / raw)
To: qemu-devel
Test case:
$ echo -e 'device_add usb-mouse\nq' | qemu-system-x86_64 -vnc :0 -monitor stdio -usb
Works in v1.0, doesn't work in master's commit ab0115e1:
qemu-system-x86_64: /work/armbru/qemu/hw/qdev.c:97: qdev_create_from_info: Assertion `bus->allow_hotplug' failed.
Same for virtio-blk-pci, so it's not specific to USB.
git-bisect:
8eb02831af6c5534d8712cb8db1104852cac26e9 is the first bad commit
commit 8eb02831af6c5534d8712cb8db1104852cac26e9
Author: Anthony Liguori <aliguori@us.ibm.com>
Date: Mon Dec 12 14:29:37 2011 -0600
dev: add an anonymous peripheral container
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] Regression: cold plug with device_add fails assertion
2011-12-21 11:01 [Qemu-devel] Regression: cold plug with device_add fails assertion Markus Armbruster
@ 2011-12-21 14:08 ` Anthony Liguori
2012-01-02 12:11 ` Markus Armbruster
0 siblings, 1 reply; 3+ messages in thread
From: Anthony Liguori @ 2011-12-21 14:08 UTC (permalink / raw)
To: Markus Armbruster; +Cc: qemu-devel
On 12/21/2011 05:01 AM, Markus Armbruster wrote:
> Test case:
>
> $ echo -e 'device_add usb-mouse\nq' | qemu-system-x86_64 -vnc :0 -monitor stdio -usb
>
> Works in v1.0, doesn't work in master's commit ab0115e1:
>
> qemu-system-x86_64: /work/armbru/qemu/hw/qdev.c:97: qdev_create_from_info: Assertion `bus->allow_hotplug' failed.
>
> Same for virtio-blk-pci, so it's not specific to USB.
Yes, see:
http://mid.gmane.org/1324334380-25278-1-git-send-email-aliguori@us.ibm.com
Which is in the latest qemu.git.
I also added a test to qemu-test to catch this.
Regards,
Anthony Liguori
>
> git-bisect:
>
> 8eb02831af6c5534d8712cb8db1104852cac26e9 is the first bad commit
> commit 8eb02831af6c5534d8712cb8db1104852cac26e9
> Author: Anthony Liguori<aliguori@us.ibm.com>
> Date: Mon Dec 12 14:29:37 2011 -0600
>
> dev: add an anonymous peripheral container
>
> Signed-off-by: Anthony Liguori<aliguori@us.ibm.com>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] Regression: cold plug with device_add fails assertion
2011-12-21 14:08 ` Anthony Liguori
@ 2012-01-02 12:11 ` Markus Armbruster
0 siblings, 0 replies; 3+ messages in thread
From: Markus Armbruster @ 2012-01-02 12:11 UTC (permalink / raw)
To: Anthony Liguori; +Cc: qemu-devel
Anthony Liguori <anthony@codemonkey.ws> writes:
> On 12/21/2011 05:01 AM, Markus Armbruster wrote:
>> Test case:
>>
>> $ echo -e 'device_add usb-mouse\nq' | qemu-system-x86_64 -vnc :0 -monitor stdio -usb
>>
>> Works in v1.0, doesn't work in master's commit ab0115e1:
>>
>> qemu-system-x86_64: /work/armbru/qemu/hw/qdev.c:97: qdev_create_from_info: Assertion `bus->allow_hotplug' failed.
>>
>> Same for virtio-blk-pci, so it's not specific to USB.
>
> Yes, see:
>
> http://mid.gmane.org/1324334380-25278-1-git-send-email-aliguori@us.ibm.com
>
> Which is in the latest qemu.git.
>
> I also added a test to qemu-test to catch this.
I verified this is fixed on current master. Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-01-02 12:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-21 11:01 [Qemu-devel] Regression: cold plug with device_add fails assertion Markus Armbruster
2011-12-21 14:08 ` Anthony Liguori
2012-01-02 12:11 ` Markus Armbruster
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).