From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:42110)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RdMq8-0002e7-38
	for qemu-devel@nongnu.org; Wed, 21 Dec 2011 09:08:20 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RdMq6-0002Wi-Em
	for qemu-devel@nongnu.org; Wed, 21 Dec 2011 09:08:16 -0500
Received: from mail-iy0-f173.google.com ([209.85.210.173]:41163)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RdMq6-0002Wa-5P
	for qemu-devel@nongnu.org; Wed, 21 Dec 2011 09:08:14 -0500
Received: by iagj37 with SMTP id j37so13523736iag.4
	for <qemu-devel@nongnu.org>; Wed, 21 Dec 2011 06:08:13 -0800 (PST)
Message-ID: <4EF1E84A.2060402@codemonkey.ws>
Date: Wed, 21 Dec 2011 08:08:10 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <m3d3bii3yp.fsf@blackfin.pond.sub.org>
In-Reply-To: <m3d3bii3yp.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] Regression: cold plug with device_add fails
	assertion
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org

On 12/21/2011 05:01 AM, Markus Armbruster wrote:
> Test case:
>
> $ echo -e 'device_add usb-mouse\nq' | qemu-system-x86_64 -vnc :0 -monitor stdio -usb
>
> Works in v1.0, doesn't work in master's commit ab0115e1:
>
> qemu-system-x86_64: /work/armbru/qemu/hw/qdev.c:97: qdev_create_from_info: Assertion `bus->allow_hotplug' failed.
>
> Same for virtio-blk-pci, so it's not specific to USB.

Yes, see:

http://mid.gmane.org/1324334380-25278-1-git-send-email-aliguori@us.ibm.com

Which is in the latest qemu.git.

I also added a test to qemu-test to catch this.

Regards,

Anthony Liguori

>
> git-bisect:
>
> 8eb02831af6c5534d8712cb8db1104852cac26e9 is the first bad commit
> commit 8eb02831af6c5534d8712cb8db1104852cac26e9
> Author: Anthony Liguori<aliguori@us.ibm.com>
> Date:   Mon Dec 12 14:29:37 2011 -0600
>
>      dev: add an anonymous peripheral container
>
>      Signed-off-by: Anthony Liguori<aliguori@us.ibm.com>
>