From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:43706) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RdNts-0003Oc-Tv for qemu-devel@nongnu.org; Wed, 21 Dec 2011 10:16:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RdNtk-00081A-9i for qemu-devel@nongnu.org; Wed, 21 Dec 2011 10:16:12 -0500 Received: from mx1.redhat.com ([209.132.183.28]:27709) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RdNtk-00080o-39 for qemu-devel@nongnu.org; Wed, 21 Dec 2011 10:16:04 -0500 Message-ID: <4EF1F82C.60606@redhat.com> Date: Wed, 21 Dec 2011 17:15:56 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1324474477-22267-1-git-send-email-avi@redhat.com> <1324474477-22267-4-git-send-email-avi@redhat.com> <4EF1E55F.1050604@codemonkey.ws> In-Reply-To: <4EF1E55F.1050604@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/8] Sort RAMBlocks by ID for migration, not by ram_addr List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, quintela@redhat.com On 12/21/2011 03:55 PM, Anthony Liguori wrote: > On 12/21/2011 07:34 AM, Avi Kivity wrote: >> ram_addr is (a) unstable (b) going away. Sort by idstr instead. >> >> Signed-off-by: Avi Kivity > > I don't see this as a problem, per say, but this is a significant > behavioral change. ram_addr does correspond roughly to the location > in memory and historically we would send memory starting from 0 upward > whereas now, the order that we send RAMBlocks will be random for all > intents and purposes. > > Again, I don't think it's a problem, but we should note this in the > commit message in case it creates a problem down the road. > I (and the new commit message) note that the sort order used to be random a while ago (before b2e0a138e), so this isn't entirely new. -- error compiling committee.c: too many arguments to function