From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:36814) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rdl2t-0003M2-5c for qemu-devel@nongnu.org; Thu, 22 Dec 2011 10:59:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rdl2r-0006Xb-Qz for qemu-devel@nongnu.org; Thu, 22 Dec 2011 10:59:03 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37095) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rdl2r-0006XQ-Gf for qemu-devel@nongnu.org; Thu, 22 Dec 2011 10:59:01 -0500 Message-ID: <4EF353C2.3010901@redhat.com> Date: Thu, 22 Dec 2011 08:58:58 -0700 From: Eric Blake MIME-Version: 1.0 References: <1324563805-4285-1-git-send-email-aliguori@us.ibm.com> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigBB71B00E996D07B0DE9526B4" Subject: Re: [Qemu-devel] [PATCH] qemu-test: add virtio-serial test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Bradbury Cc: Anthony Liguori , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigBB71B00E996D07B0DE9526B4 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 12/22/2011 08:46 AM, Alex Bradbury wrote: >> + >> +in_host() { >> + tmpchr=3D$tmpdir/chr.log >=20 > By far the most common error likely to appear in any of these test > scripts is insufficient shell quoting causing e.g. breakages when the > scripts are run from a directory with spaces. Shell assignments do not need quoting, since they are not subject to argument splitting or filename expansion in the first place. Blindly requiring double-quoting of all shell variables and command substitutions can actually introduce problems if you care about portability to ancient shells, since constructs like: var=3D`command "with quotes"` are actually MORE portable than: var=3D"`command "with quotes"`" --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigBB71B00E996D07B0DE9526B4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJO81PDAAoJEKeha0olJ0NqwicH/1iifZH1X0DXD7YbVWrN68W9 X3b6swEqjJBw3rZiiwo4y67B08ck3ZXLbIK37Hsn9vEVtwRq+ZIfutUfrAHmvcGu xcDlwmhYzE0OfregqroV1EClMvocNY+gh5zPJElxtFSqv1Ovn4E0FtxNvclPO6Po aksGRzWE2aKr6aVbYJDujpzU22DiLKyKtlk61iLxh6omqIIWtWttBlFno2H3uCXo UqTmBq+oZNJI4H0MlzpfZQi3L5JXSKdXW5QUCcaaxTdfDrB5Yiv3I8wZpKjMk/V0 IvG19REwvx4RatimE92pKLhW7Y8mhiaq6ayiETbXXhGUkmgBg9+dXSvdtBV9tCM= =FYs1 -----END PGP SIGNATURE----- --------------enigBB71B00E996D07B0DE9526B4--