From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:43046)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Re170-0006tl-Un
	for qemu-devel@nongnu.org; Fri, 23 Dec 2011 04:08:23 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Re16v-0003s2-BI
	for qemu-devel@nongnu.org; Fri, 23 Dec 2011 04:08:22 -0500
Received: from mail-iy0-f173.google.com ([209.85.210.173]:61088)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Re16v-0003rv-71
	for qemu-devel@nongnu.org; Fri, 23 Dec 2011 04:08:17 -0500
Received: by iagj37 with SMTP id j37so16887258iag.4
	for <qemu-devel@nongnu.org>; Fri, 23 Dec 2011 01:08:16 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4EF444FB.4030903@redhat.com>
Date: Fri, 23 Dec 2011 10:08:11 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1324183735-16930-1-git-send-email-ronniesahlberg@gmail.com>
	<1324183735-16930-2-git-send-email-ronniesahlberg@gmail.com>
	<4EEDEF11.3000708@redhat.com>
	<CAN05THTbnZdjweJz5NLk7OsHMnNJJnY=kXoUi56pabsfijvRtA@mail.gmail.com>
In-Reply-To: <CAN05THTbnZdjweJz5NLk7OsHMnNJJnY=kXoUi56pabsfijvRtA@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] iSCSI: add configuration variables for
	iSCSI
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: ronnie sahlberg <ronniesahlberg@gmail.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org

On 12/22/2011 09:51 PM, ronnie sahlberg wrote:
> The difference between qcow2 and iscsi and the problem is that .open()
> is called for all devices before the monitor is started, so .open() is
> called before we would have a chance to even hand the password to
> qemu.
>
> For qcow2 this is not a problem since even if the file is password
> protected the file header is not, so you can still open the file and
> read the header (to discover it is password protected) without knowing
> the password.
> So qcow2 can still open the file and do all the sanity checks it needs
> without yet knowing the password.

You're right.

I see that the libvirt driver for rbd simply passes it on the command 
line.  I hope I'll be able to review the patch further today.

Paolo