From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:44522) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RfXmt-000154-3m for qemu-devel@nongnu.org; Tue, 27 Dec 2011 09:13:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RfXms-0000Iy-BX for qemu-devel@nongnu.org; Tue, 27 Dec 2011 09:13:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56332) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RfXms-0000Ip-2v for qemu-devel@nongnu.org; Tue, 27 Dec 2011 09:13:54 -0500 Message-ID: <4EF9D29A.5030409@redhat.com> Date: Tue, 27 Dec 2011 16:13:46 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1324893824-13558-1-git-send-email-i.mitsyanko@samsung.com> <1324893824-13558-3-git-send-email-i.mitsyanko@samsung.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/3] hw/sd.c: add SD card save/load support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Mitsyanko Igor , e.voevodin@samsung.com, Juan Quintela , qemu-devel@nongnu.org, kyungmin.park@samsung.com, d.solodkiy@samsung.com, m.kozlov@samsung.com, jehyung.lee@samsung.com On 12/26/2011 04:58 PM, Peter Maydell wrote: > > > > void sd_enable(SDState *sd, int enable) > > { > > - sd->enable = enable; > > + sd->enable = enable ? true : false; > > This kind of thing is why I don't like bool :-) /me leaps to bool's defence: sd->enable = enable should work just fine. The assignment is equivalent to sd->enable = enable != 0, as conversion to bool coerces the value to true/false. -- error compiling committee.c: too many arguments to function