From: Mitsyanko Igor <i.mitsyanko@samsung.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
e.voevodin@samsung.com, "Juan Quintela" <quintela@redhat.com>,
kyungmin.park@samsung.com, d.solodkiy@samsung.com,
"Paolo Bonzini" <pbonzini@redhat.com>,
m.kozlov@samsung.com, "Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH 1/3] vmstate: introduce calc_size VMStateField
Date: Wed, 28 Dec 2011 11:41:19 +0400 [thread overview]
Message-ID: <4EFAC81F.8050004@samsung.com> (raw)
In-Reply-To: <4EF9C3D7.4070008@suse.de>
On 12/27/2011 05:10 PM, Andreas Färber wrote:
> Am 27.12.2011 09:11, schrieb Mitsyanko Igor:
>> On 12/26/2011 07:20 PM, Peter Maydell wrote:
>>> On 26 December 2011 10:03, Mitsyanko Igor<i.mitsyanko@samsung.com>
>>> wrote:
>>>> diff --git a/hw/hw.h b/hw/hw.h
>>>> index efa04d1..8ce4475 100644
>>>> --- a/hw/hw.h
>>>> +++ b/hw/hw.h
>>>> @@ -303,9 +303,9 @@ enum VMStateFlags {
>>>> VMS_ARRAY_OF_POINTER = 0x040,
>>>> VMS_VARRAY_UINT16 = 0x080, /* Array with size in uint16_t
>>>> field */
>>>> VMS_VBUFFER = 0x100, /* Buffer with size in int32_t
>>>> field */
>>>> - VMS_MULTIPLY = 0x200, /* multiply "size" field by
>>>> field_size */
>>>> - VMS_VARRAY_UINT8 = 0x400, /* Array with size in uint8_t
>>>> field*/
>>>> - VMS_VARRAY_UINT32 = 0x800, /* Array with size in uint32_t
>>>> field*/
>>>> + VMS_CALC_SIZE = 0x200, /* calculate size of dynamic
>>>> buffer */
>>>> + VMS_VARRAY_UINT8 = 0x400, /* Array with size in uint8_t
>>>> field */
>>>> + VMS_VARRAY_UINT32 = 0x800, /* Array with size in uint32_t
>>>> field */
>>>
>>> These unrelated whitespace fixes are confusing -- please drop them.
>> QEMU wiki here http://wiki.qemu.org/Contribute/SubmitAPatch states that
>> it's ok :)
>>> It's OK to fix coding style issues in the immediate area (few lines)>
>> of the lines you're changing.)
>
> It's not really a Coding Style issue though (just an aesthetic one),
> what's meant by the quote is to fix braces around the lines you touch.
>
> I'd suggest to put it in a separate preceding patch, then it gets fixed
> and we can still better see what you're changing here.
If v2 of this patch will be accepted and we will drop VMS_MULTIPLY, I
could add required spaces together with changing values given to
VMS_VARRAY_UINT8 and VMS_VARRAY_UINT32 flags. Or this can be done by
Paolo Bonzini in his "split hw/hw.h" patch, I cc him just in case he
wouldn't mind to do this.
> (I'm in need of a mechanism like this for AHCI so please cc Juan and me
> on v2 of this patch.)
>
> Andreas
>
I'm also considering to change local size variable in
vmstate_load_state() and vmstate_save_state() to size_t, it makes no
sense to convert size_t field->size to intermediate int type just to
pass it again as size_t to get() function.
--
Mitsyanko Igor
ASWG, Moscow R&D center, Samsung Electronics
email: i.mitsyanko@samsung.com
next prev parent reply other threads:[~2011-12-28 7:41 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-26 10:03 [Qemu-devel] [PATCH 0/3] Improve SD controllers emulation Mitsyanko Igor
2011-12-26 10:03 ` [Qemu-devel] [PATCH 1/3] vmstate: introduce calc_size VMStateField Mitsyanko Igor
2011-12-26 15:20 ` Peter Maydell
2011-12-27 8:11 ` Mitsyanko Igor
2011-12-27 13:10 ` Andreas Färber
2011-12-28 7:41 ` Mitsyanko Igor [this message]
2011-12-27 7:54 ` [Qemu-devel] [PATCH V2 1/3] vmstate: introduce get_bufsize entry in VMStateField Mitsyanko Igor
2011-12-26 10:03 ` [Qemu-devel] [PATCH 2/3] hw/sd.c: add SD card save/load support Mitsyanko Igor
2011-12-26 14:58 ` Peter Maydell
2011-12-27 11:27 ` Mitsyanko Igor
2011-12-27 13:27 ` Andreas Färber
2011-12-27 13:54 ` Mitsyanko Igor
2011-12-27 14:13 ` Avi Kivity
2011-12-27 21:30 ` Peter Maydell
2011-12-28 9:50 ` Avi Kivity
2011-12-26 10:03 ` [Qemu-devel] [PATCH 3/3] hw/: Introduce spec. ver. 2.00 compliant SD host controller Mitsyanko Igor
2011-12-26 11:35 ` malc
2011-12-28 12:08 ` [Qemu-devel] [PATCH V2 0/3] Improve SD controllers emulation Mitsyanko Igor
2011-12-28 12:08 ` [Qemu-devel] [PATCH V2 1/3] vmstate: introduce get_bufsize entry in VMStateField Mitsyanko Igor
2011-12-28 12:08 ` [Qemu-devel] [PATCH V2 2/3] hw/sd.c: add SD card save/load support Mitsyanko Igor
2011-12-28 13:26 ` Peter Maydell
2011-12-28 14:02 ` Mitsyanko Igor
2011-12-28 14:41 ` Peter Maydell
2011-12-28 12:08 ` [Qemu-devel] [PATCH V2 3/3] hw: Introduce spec. ver. 2.00 compliant SD host controller Mitsyanko Igor
2011-12-28 15:32 ` [Qemu-devel] [PATCH V3 0/5] Improve SD controllers emulation Mitsyanko Igor
2011-12-28 15:32 ` [Qemu-devel] [PATCH V3 1/5] vmstate: introduce get_bufsize entry in VMStateField Mitsyanko Igor
2012-01-19 13:40 ` Andreas Färber
2011-12-28 15:32 ` [Qemu-devel] [PATCH V3 2/5] hw/sd.c: add SD card save/load support Mitsyanko Igor
2011-12-28 15:32 ` [Qemu-devel] [PATCH V3 3/5] hw/sd.c: convert wp_groups, expecting_acmd and enable to bool Mitsyanko Igor
2011-12-28 15:32 ` [Qemu-devel] [PATCH V3 4/5] hw/sd.c: convert wp_switch and spi " Mitsyanko Igor
2011-12-28 15:32 ` [Qemu-devel] [PATCH V3 5/5] hw: Introduce spec. ver. 2.00 compliant SD host controller Mitsyanko Igor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EFAC81F.8050004@samsung.com \
--to=i.mitsyanko@samsung.com \
--cc=afaerber@suse.de \
--cc=d.solodkiy@samsung.com \
--cc=e.voevodin@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=m.kozlov@samsung.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).