From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:58160)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1Rfq9q-0004rq-ES
	for qemu-devel@nongnu.org; Wed, 28 Dec 2011 04:50:51 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1Rfq9p-0000FO-BL
	for qemu-devel@nongnu.org; Wed, 28 Dec 2011 04:50:50 -0500
Received: from mx1.redhat.com ([209.132.183.28]:42348)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1Rfq9p-0000FI-3T
	for qemu-devel@nongnu.org; Wed, 28 Dec 2011 04:50:49 -0500
Message-ID: <4EFAE673.6060107@redhat.com>
Date: Wed, 28 Dec 2011 11:50:43 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1324893824-13558-1-git-send-email-i.mitsyanko@samsung.com>
	<1324893824-13558-3-git-send-email-i.mitsyanko@samsung.com>
	<CAFEAcA-6JD8rQd_RYFmxaPO2jdZS2bzY--eCmgp2Nc=XcCAdSg@mail.gmail.com>
	<4EF9D29A.5030409@redhat.com>
	<CAFEAcA-xEe9ZPxSYe5JSGVjyLSFdcjqQwfdrGAyfzgU7H+zb6Q@mail.gmail.com>
In-Reply-To: <CAFEAcA-xEe9ZPxSYe5JSGVjyLSFdcjqQwfdrGAyfzgU7H+zb6Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/3] hw/sd.c: add SD card save/load support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Mitsyanko Igor <i.mitsyanko@samsung.com>, e.voevodin@samsung.com, Juan Quintela <quintela@redhat.com>, qemu-devel@nongnu.org, kyungmin.park@samsung.com, d.solodkiy@samsung.com, m.kozlov@samsung.com, jehyung.lee@samsung.com

On 12/27/2011 11:30 PM, Peter Maydell wrote:
> On 27 December 2011 14:13, Avi Kivity <avi@redhat.com> wrote:
> > On 12/26/2011 04:58 PM, Peter Maydell wrote:
> >> >  void sd_enable(SDState *sd, int enable)
> >> >  {
> >> > -    sd->enable = enable;
> >> > +    sd->enable = enable ? true : false;
> >>
> >> This kind of thing is why I don't like bool :-)
> >
> > /me leaps to bool's defence:
> >
> >  sd->enable = enable should work just fine.
>
> This is true, but the code snippet also illustrates that it sits
> oddly to have the internal state variable be bool when the external
> facing function's API is clearly using the traditional C style of
> int-for-booleans.

We should change those too.  bool is self-documenting.

> Plus 'bool' gives me C++ flashbacks :-)

And QOM doesn't?  How about
glue(glue(glue(cirrus_colorexpand_pattern_transp_, ROP_NAME), _),DEPTH)?

-- 
error compiling committee.c: too many arguments to function