From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:55269) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rfz0z-0003LT-Id for qemu-devel@nongnu.org; Wed, 28 Dec 2011 14:18:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rfz0y-0001RB-CT for qemu-devel@nongnu.org; Wed, 28 Dec 2011 14:18:17 -0500 Received: from fmmailgate02.web.de ([217.72.192.227]:59748) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rfz0x-0001R3-VY for qemu-devel@nongnu.org; Wed, 28 Dec 2011 14:18:16 -0500 Received: from moweb002.kundenserver.de (moweb002.kundenserver.de [172.19.20.108]) by fmmailgate02.web.de (Postfix) with ESMTP id 57F611BE7D0EB for ; Wed, 28 Dec 2011 20:18:14 +0100 (CET) Message-ID: <4EFB6B73.9060900@web.de> Date: Wed, 28 Dec 2011 20:18:11 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <4EF9DFBA.2020808@web.de> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigE9C4BB2AA63D43A3C46701A1" Subject: Re: [Qemu-devel] [PATCH] Expose tsc deadline timer cpuid to guest List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Liu, Jinsong" Cc: "qemu-devel@nongnu.org" , Marcelo Tosatti , Avi Kivity , kvm , Alexey Zaytsev This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigE9C4BB2AA63D43A3C46701A1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2011-12-28 18:35, Liu, Jinsong wrote: >>> diff --git a/qemu-kvm.h b/qemu-kvm.h >>> index 2bd5602..8c6c2ea 100644 >>> --- a/qemu-kvm.h >>> +++ b/qemu-kvm.h >>> @@ -260,6 +260,7 @@ extern int kvm_irqchip; >>> extern int kvm_pit; >>> extern int kvm_pit_reinject; >>> extern unsigned int kvm_shadow_memory; >>> +extern int tsc_deadline_timer; >>> >>> int kvm_handle_tpr_access(CPUState *env); >>> void kvm_tpr_enable_vapic(CPUState *env); >>> diff --git a/qemu-options.hx b/qemu-options.hx >>> index f6df6b9..eff6644 100644 >>> --- a/qemu-options.hx >>> +++ b/qemu-options.hx >>> @@ -2619,6 +2619,9 @@ DEF("no-kvm-pit-reinjection", 0, >>> QEMU_OPTION_no_kvm_pit_reinjection, "-no-kvm-pit-reinjection\n" >>> " disable KVM kernel mode PIT interrupt >>> reinjection\n", QEMU_ARCH_I386) +DEF("no-tsc-deadline-timer", >>> 0, QEMU_OPTION_no_tsc_deadline_timer, + "-no-tsc-deadline-timer =20 >>> disable tsc deadline timer\n", + QEMU_ARCH_I386) >> >> Hmm, I would really prefer to stop adding switches like this. They >> won't make it upstream anyway. >=20 > OK, I will try to write a patch w/ better user control cpuid method, i.= e. by plus_features and minus_features. Yep, that would be better. >=20 >> >> Can't this control be attached to legacy qemu machine models, ie. here= >> anything <=3D pc-1.0? See how we handle kvmclock. >> >=20 > You mean, by adding input para like pc_init1(..., kvmclock_enabled, tsc= deadline_enabled)? > I think that's not a good way. I think it is mandatory as older qemu versions won't expose tscdeadline to the guest, thus newer versions must not do this when emulating older machines. > With more and more cpuid features (N) controlled in this way, machine m= odels would be 2^N. We likely need a better way to express this via code, I agree. Likely something declarative as for compat_props. Jan --------------enigE9C4BB2AA63D43A3C46701A1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk77a3MACgkQitSsb3rl5xQDRwCglrmPREm1C4gNc2mjhpNYV/1o BUIAoNxKHYGMJhKMlm62F+zq1dLgp9VY =KgrE -----END PGP SIGNATURE----- --------------enigE9C4BB2AA63D43A3C46701A1--