From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Amit Shah <amit.shah@redhat.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCHv2] Fix virtio-console failure on unconnected pty
Date: Thu, 29 Dec 2011 15:32:14 +0100 [thread overview]
Message-ID: <4EFC79EE.6020000@de.ibm.com> (raw)
In-Reply-To: <20111229142658.GD4576@amit.redhat.com>
> port->throttled never becomes true for qemu.
Huh? What did I miss below?
if (ret == -EAGAIN || (ret >= 0 && ret < buf_size)) {
virtio_serial_throttle_port(port, true);
|
|
V
void virtio_serial_throttle_port(VirtIOSerialPort *port, bool throttle)
{
if (!port) {
return;
}
trace_virtio_serial_throttle_port(port->id, throttle);
port->throttled = throttle; <-------------------- WHOOOT!
if (throttle) {
return;
}
qemu_bh_schedule(port->bh);
}
next prev parent reply other threads:[~2011-12-29 14:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-15 12:44 [Qemu-devel] [RFC] virtio-console fails on unconnected pty Christian Borntraeger
2011-12-16 9:23 ` Amit Shah
2011-12-29 12:47 ` [Qemu-devel] [PATCHv2] Fix virtio-console failure " Christian Borntraeger
2011-12-29 13:27 ` Amit Shah
2011-12-29 13:39 ` Andreas Färber
2011-12-29 14:04 ` Amit Shah
2011-12-29 14:16 ` Christian Borntraeger
2011-12-29 14:19 ` Christian Borntraeger
2011-12-29 14:26 ` Amit Shah
2011-12-29 14:32 ` Christian Borntraeger [this message]
2011-12-29 14:56 ` Amit Shah
2011-12-29 15:14 ` Christian Borntraeger
2011-12-29 15:14 ` Amit Shah
2012-01-02 15:34 ` Alexander Graf
2012-01-02 15:41 ` Christian Borntraeger
2012-01-02 16:55 ` Alexander Graf
2012-01-03 15:49 ` Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EFC79EE.6020000@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=agraf@suse.de \
--cc=amit.shah@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).