From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:33110)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RgL0m-0002SZ-J0
	for qemu-devel@nongnu.org; Thu, 29 Dec 2011 13:47:33 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RgL0l-0002YY-IQ
	for qemu-devel@nongnu.org; Thu, 29 Dec 2011 13:47:32 -0500
Received: from mail-yw0-f45.google.com ([209.85.213.45]:57380)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RgL0l-0002YU-G4
	for qemu-devel@nongnu.org; Thu, 29 Dec 2011 13:47:31 -0500
Received: by yhgg71 with SMTP id g71so9719546yhg.4
	for <qemu-devel@nongnu.org>; Thu, 29 Dec 2011 10:47:31 -0800 (PST)
Message-ID: <4EFCB5BF.9020406@codemonkey.ws>
Date: Thu, 29 Dec 2011 12:47:27 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1322765012-3164-1-git-send-email-aliguori@us.ibm.com>	<1322765012-3164-3-git-send-email-aliguori@us.ibm.com>
	<CAFEAcA993T5YD-4QArMXE2TafoL+Ki_+2K6vx6heV+L4ihMLOw@mail.gmail.com>
In-Reply-To: <CAFEAcA993T5YD-4QArMXE2TafoL+Ki_+2K6vx6heV+L4ihMLOw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC v2 2/6] qtest: add support for target-i386 -M
 pc
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org

On 12/29/2011 11:40 AM, Peter Maydell wrote:
> On 1 December 2011 18:43, Anthony Liguori<aliguori@us.ibm.com>  wrote:
>> This involves forcing the CPU into the halted state if qtest is enabled and
>> replacing the local APIC with the qtest interrupt controller.
>>
>> It should be pretty straight forward to do the same for other machine types on
>> other architectures.
>
> Having to modify every machine type seems to me like a huge red flag that this
> is the wrong approach for device level tests. Surely the right thing is to
> (a) instantiate the device (b) manipulate it via its publicly exposed interfaces
> (ie the memory regions, gpio signals, irqs, etc etc) ?

The problem is the machine creation.  Once we convert everything to QOM 
including machine setup, yes, this is what we can do.

Regards,

Anthony Liguori

>
> Alternatively if you're just testing features of the device as it
> is wired up on the board then you want something that generates an
> image that can just be run on the unmodified QEMU model; that then
> lets you cross check by running your tests on real hardware.
>
> -- PMM
>