From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:60305) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RgPDy-00009p-CZ for qemu-devel@nongnu.org; Thu, 29 Dec 2011 18:17:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RgPDx-0003Su-EA for qemu-devel@nongnu.org; Thu, 29 Dec 2011 18:17:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47354) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RgPDx-0003Sq-4P for qemu-devel@nongnu.org; Thu, 29 Dec 2011 18:17:25 -0500 Message-ID: <4EFCF505.9030004@redhat.com> Date: Thu, 29 Dec 2011 21:17:25 -0200 From: Lucas Meneghel Rodrigues MIME-Version: 1.0 References: <4EEF70B4.3070109@us.ibm.com> <4EF73EF5.8050606@redhat.com> <4EF88EC0.8020301@codemonkey.ws> <4EF8FC88.70809@redhat.com> <4EFA4829.4000207@redhat.com> <4EFA80EA.3050405@codemonkey.ws> <4EFAA2A2.4000107@redhat.com> <4EFB2764.7040006@codemonkey.ws> <4EFB2F36.2090408@redhat.com> <4EFB46DD.4000905@codemonkey.ws> <4EFB5014.9030609@redhat.com> <4EFC7B72.9050802@redhat.com> <4EFC97C3.4080603@codemonkey.ws> <4EFC9AFF.5070707@redhat.com> <4EFC9D2B.1020606@codemonkey.ws> In-Reply-To: <4EFC9D2B.1020606@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [ANNOUNCE] qemu-test: a set of tests scripts for QEMU List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Stefan Hajnoczi , cleber@redhat.com, dlaor@redhat.com, qemu-devel , Gerd Hoffmann , Cleber Rosa , Avi Kivity On 12/29/2011 03:02 PM, Anthony Liguori wrote: > On 12/29/2011 10:53 AM, Avi Kivity wrote: >> On 12/29/2011 06:39 PM, Anthony Liguori wrote: >> >> It might have made sense to split the kvm-testing functionality of >> autotest, and have autotest drive that. We could even have called it >> qemu-test. > > I specifically advocated this during Lucas' KVM Forum talk and he was > strongly opposed to it. Ok, this is a point where I have failed in communicating things. I've watched the presentation on video just to see if my memory was not betraying me, and I wouldn't say I was 'strongly opposed', it's just that there are some practical problems, not impossible to overcome of course, but worth thinking. * We rely on a fair bit of autotest libraries/API, so by extracting the APIs we rely on to start a new project we'd be creating some code duplication, and updates/bugfixes on the autotest API wouldn't be easily carried on to the new project. * I'm not sure that this per se would fix the perceived problems with the tests. It'd be nearly the same code, just outside the autotest tree, I fail to see how that would be much better, and therefore, justify the work on doing this. Of course I might be wrong. > I think kvm autotest would get a lot more interest if the test cases > were pulled out of autotest, made more stand alone. They also should be > more Unix like being divided into individual executables with > independent command line options over a single do-everything > configuration file. You have a point with regards to having the test cases more stand alone, but it's not as easy as one would think mainly because of the large amount of user configurable options that we have to pass to the tests. This is a place where the config file format shines, since we just have to override some parameters on different variants to have a test working among Windows and Linux guests, for example, all expressed in a concise way. The config files might look enormous, but they are actually pretty small compared with the amount of test combinations we can get out of it. This is nothing I'd call insurmountable as well. If I get more feedback of people saying "Ok, this would make things better for me and make me more interested", then we'll go that route. I'm sorry if I gave the impression I was strongly opposed to your idea.