From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:52146) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RgxgR-0003l0-DS for qemu-devel@nongnu.org; Sat, 31 Dec 2011 07:05:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RgxgQ-0003ZS-7i for qemu-devel@nongnu.org; Sat, 31 Dec 2011 07:05:07 -0500 Received: from cantor2.suse.de ([195.135.220.15]:50888 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RgxgQ-0003Y9-1m for qemu-devel@nongnu.org; Sat, 31 Dec 2011 07:05:06 -0500 Message-ID: <4EFEFA20.4070501@suse.de> Date: Sat, 31 Dec 2011 13:03:44 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1325307291-6334-1-git-send-email-rth@twiddle.net> <1325307291-6334-4-git-send-email-rth@twiddle.net> In-Reply-To: <1325307291-6334-4-git-send-email-rth@twiddle.net> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 4/4] target-mips: Fix MIPS_DEBUG. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, Aurelien Jarno Am 31.12.2011 05:54, schrieb Richard Henderson: > The macro uses the DisasContext. Pass it around as needed. This fixes a build failure, right? Order it first then? Since there's no cover letter, series looks mostly good. Some minor comments. >=20 > Signed-off-by: Richard Henderson > --- > target-mips/translate.c | 80 ++++++++++++++++++++++++++-------------= -------- > 1 files changed, 44 insertions(+), 36 deletions(-) >=20 > diff --git a/target-mips/translate.c b/target-mips/translate.c > index 8908c8c..11272b6 100644 > --- a/target-mips/translate.c > +++ b/target-mips/translate.c > @@ -1489,7 +1489,8 @@ static void gen_arith_imm (CPUState *env, DisasCo= ntext *ctx, uint32_t opc, > } > =20 > /* Logic with immediate operand */ > -static void gen_logic_imm (CPUState *env, uint32_t opc, int rt, int rs= , int16_t imm) > +static void gen_logic_imm (CPUState *env, DisasContext *ctx, uint32_t = opc, > + int rt, int rs, int16_t imm) When you touch the declaration, please fix Coding Style by removing the extra space before the bracket. Applies to 1-4. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg