From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:48401) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rh7L1-0003UP-KG for qemu-devel@nongnu.org; Sat, 31 Dec 2011 17:23:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rh7L0-0008Vl-Jv for qemu-devel@nongnu.org; Sat, 31 Dec 2011 17:23:39 -0500 Received: from mail-iy0-f173.google.com ([209.85.210.173]:53129) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rh7L0-0008Vh-EG for qemu-devel@nongnu.org; Sat, 31 Dec 2011 17:23:38 -0500 Received: by iagj37 with SMTP id j37so31608512iag.4 for ; Sat, 31 Dec 2011 14:23:37 -0800 (PST) Sender: Richard Henderson Message-ID: <4EFF8B61.7020908@twiddle.net> Date: Sun, 01 Jan 2012 09:23:29 +1100 From: Richard Henderson MIME-Version: 1.0 References: <1325307291-6334-1-git-send-email-rth@twiddle.net> <1325307291-6334-4-git-send-email-rth@twiddle.net> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/4] target-mips: Fix MIPS_DEBUG. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org, Aurelien Jarno , afaerber@suse.de On 12/31/2011 10:50 PM, Peter Maydell wrote: >> +static void gen_logic_imm (CPUState *env, DisasContext *ctx, uint32_t opc, >> + int rt, int rs, int16_t imm) >> { >> target_ulong uimm; >> const char *opn = "imm logic"; > > Am I missing something, or does gen_logic_imm() not actually use env at all? > Maybe we should be replacing env with ctx in the parameter list in some/most > of these functions rather than adding it? You're not missing anything. Really, env should not be used by anything in that file except for the outermost gen_intermediate_code_internal, which already copies the bits that are needed to the ctx. Cleaning up incorrect uses of env throughout that file is a larger job. r~