From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:47602)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1Rhk1R-0006b7-P8
	for qemu-devel@nongnu.org; Mon, 02 Jan 2012 10:42:02 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1Rhk1Q-0000CD-R2
	for qemu-devel@nongnu.org; Mon, 02 Jan 2012 10:42:01 -0500
Received: from e06smtp10.uk.ibm.com ([195.75.94.106]:57035)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1Rhk1Q-0000C7-I4
	for qemu-devel@nongnu.org; Mon, 02 Jan 2012 10:42:00 -0500
Received: from /spool/local
	by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <borntraeger@de.ibm.com>;
	Mon, 2 Jan 2012 15:41:58 -0000
Received: from d06av09.portsmouth.uk.ibm.com (d06av09.portsmouth.uk.ibm.com
	[9.149.37.250])
	by d06nrmr1707.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with
	ESMTP id q02FfpRP2424900
	for <qemu-devel@nongnu.org>; Mon, 2 Jan 2012 15:41:52 GMT
Received: from d06av09.portsmouth.uk.ibm.com (loopback [127.0.0.1])
	by d06av09.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with
	ESMTP id q02FfpCN004212
	for <qemu-devel@nongnu.org>; Mon, 2 Jan 2012 08:41:51 -0700
Message-ID: <4F01D045.1060108@de.ibm.com>
Date: Mon, 02 Jan 2012 16:41:57 +0100
From: Christian Borntraeger <borntraeger@de.ibm.com>
MIME-Version: 1.0
References: <4EE9EBB9.9020300@de.ibm.com> <4EFC616F.4060806@de.ibm.com>
	<20111229140407.GC4576@amit.redhat.com>
	<4EFC7657.5090804@de.ibm.com>
	<20111229142658.GD4576@amit.redhat.com>
	<4EFC79EE.6020000@de.ibm.com>
	<20111229151434.GF4576@amit.redhat.com>
	<CC61F79E-95FD-47DD-880D-1099DFA62BFE@suse.de>
In-Reply-To: <CC61F79E-95FD-47DD-880D-1099DFA62BFE@suse.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCHv2] Fix virtio-console failure on
	unconnected pty
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Amit Shah <amit.shah@redhat.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On 02/01/12 16:34, Alexander Graf wrote:
>>>            if (ret == -EAGAIN || (ret >= 0 && ret < buf_size)) {
>>>                virtio_serial_throttle_port(port, true);
>>
>> Ah; I see what's happening.  pty_chr_write() returns 0 if a client
>> isn't yet connected.
>>
>> This is different from the buggy tcp_chr_write() code, which just
>> returns 'len', i.e. a successful write.  And since I've only tested
>> with tcp/unix sockets, I couldn't see why throttling could get
>> enabled.
> 
> So what's the conclusion then? :)

My conclusion is that with my patch virtio-console on a pty works, without
it doesnt. :-) 
I think Amit said that he is going to apply the patch.

Christian