From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:53423) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RhmAO-0005Lz-Va for qemu-devel@nongnu.org; Mon, 02 Jan 2012 12:59:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RhmAO-0000jC-4g for qemu-devel@nongnu.org; Mon, 02 Jan 2012 12:59:24 -0500 Received: from mail-gx0-f173.google.com ([209.85.161.173]:53318) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RhmAO-0000j8-0w for qemu-devel@nongnu.org; Mon, 02 Jan 2012 12:59:24 -0500 Received: by ggnk1 with SMTP id k1so11343200ggn.4 for ; Mon, 02 Jan 2012 09:59:23 -0800 (PST) Sender: Paolo Bonzini Message-ID: <4F01F075.2070706@redhat.com> Date: Mon, 02 Jan 2012 18:59:17 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1324399916-21315-1-git-send-email-aliguori@us.ibm.com> <1324399916-21315-2-git-send-email-aliguori@us.ibm.com> In-Reply-To: <1324399916-21315-2-git-send-email-aliguori@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 01/27] qom: add the base Object class List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, Markus Armbruster On 12/20/2011 05:51 PM, Anthony Liguori wrote: > hw/object.c | 469 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > hw/object.h | 427 +++++++++++++++++++++++++++++++++++++++++++++++++++ A couple more remarks: 1) Please put it outside hw/ 2) Why do you need a list for the interface objects at all? You can make obj->interfaces point to a single blob, and initialize the objects in place. You only need to store the number of interfaces into the TypeImpl or in the object header, or add a dummy Interface at the end whose contents are all-zero. Paolo