From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:37431) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RhqB3-0003ct-BI for qemu-devel@nongnu.org; Mon, 02 Jan 2012 17:16:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RhqB2-0006r6-FV for qemu-devel@nongnu.org; Mon, 02 Jan 2012 17:16:21 -0500 Received: from mail-iy0-f173.google.com ([209.85.210.173]:63796) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RhqB2-0006r2-7s for qemu-devel@nongnu.org; Mon, 02 Jan 2012 17:16:20 -0500 Received: by iagj37 with SMTP id j37so34652087iag.4 for ; Mon, 02 Jan 2012 14:16:19 -0800 (PST) Sender: Richard Henderson Message-ID: <4F022CAD.80400@twiddle.net> Date: Tue, 03 Jan 2012 09:16:13 +1100 From: Richard Henderson MIME-Version: 1.0 References: <1325522015-503-1-git-send-email-avi@redhat.com> <1325522015-503-9-git-send-email-avi@redhat.com> In-Reply-To: <1325522015-503-9-git-send-email-avi@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 08/16] Convert IO_MEM_{RAM, ROM, UNASSIGNED, NOTDIRTY} to MemoryRegions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: qemu-devel@nongnu.org On 01/03/2012 03:33 AM, Avi Kivity wrote: > - if (is_ram_rom_romd(pd)) { > + if (!is_ram_rom_romd(pd)) { Should be merged with a previous patch. r~