From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:36618) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ri015-0000wh-GT for qemu-devel@nongnu.org; Tue, 03 Jan 2012 03:46:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ri014-0003aV-ED for qemu-devel@nongnu.org; Tue, 03 Jan 2012 03:46:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36790) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ri014-0003aK-6V for qemu-devel@nongnu.org; Tue, 03 Jan 2012 03:46:42 -0500 Message-ID: <4F02C06E.3080208@redhat.com> Date: Tue, 03 Jan 2012 10:46:38 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1325522015-503-1-git-send-email-avi@redhat.com> <1325522015-503-7-git-send-email-avi@redhat.com> <4F022872.4090701@twiddle.net> In-Reply-To: <4F022872.4090701@twiddle.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 06/16] Avoid range comparisons on io index types List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org On 01/02/2012 11:58 PM, Richard Henderson wrote: > On 01/03/2012 03:33 AM, Avi Kivity wrote: > > - if ((pd & ~TARGET_PAGE_MASK) > IO_MEM_ROM && !(pd & IO_MEM_ROMD)) { > > + if (!is_ram_rom(pd) && !(pd & IO_MEM_ROMD)) { > > /* IO memory case (romd handled later) */ > > Perhaps (!is_ram_rom_romd(pd))? Yeah, will change. > At least that's what I see from DeMorgan's, even though it > doesn't quite seem to tally with the comment... The comment actually fits both (!is_ram_rom && !is_romd()) and (!is_ram_rom && is_romd()), since romd acts like both rom and I/O memory. The code appears to be correct. -- error compiling committee.c: too many arguments to function