From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:44365) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ri4a3-0006UA-Fe for qemu-devel@nongnu.org; Tue, 03 Jan 2012 08:39:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ri4a2-0005EA-Fk for qemu-devel@nongnu.org; Tue, 03 Jan 2012 08:39:07 -0500 Received: from mail-iy0-f173.google.com ([209.85.210.173]:37964) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ri4a2-0005E6-2x for qemu-devel@nongnu.org; Tue, 03 Jan 2012 08:39:06 -0500 Received: by iagj37 with SMTP id j37so35875973iag.4 for ; Tue, 03 Jan 2012 05:39:05 -0800 (PST) Message-ID: <4F0304F5.9060506@codemonkey.ws> Date: Tue, 03 Jan 2012 07:39:01 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1325551939-24749-1-git-send-email-aliguori@us.ibm.com> <1325551939-24749-11-git-send-email-aliguori@us.ibm.com> <4F02C501.5090000@redhat.com> In-Reply-To: <4F02C501.5090000@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 10/30] qdev: don't access name through info List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Markus Armbruster , Anthony Liguori , qemu-devel@nongnu.org, =?ISO-8859-1?Q?Andreas_F=E4rber?= On 01/03/2012 03:06 AM, Paolo Bonzini wrote: > On 01/03/2012 01:51 AM, Anthony Liguori wrote: >> d->nic = qemu_new_nic(&net_e1000_info,&d->conf, >> - qdev_get_info(&d->dev.qdev)->name, d->dev.qdev.id, d); >> + object_get_typename(OBJECT(d)), d->dev.qdev.id, d); > > It's a pity that this loses type-safety. You mean at run time or because OBJECT() cast is so lose? We can fix the later.. Regards, Anthony Liguori > > Perhaps we should look at adding a warning for "unsafe" pointer casts to GCC. > > Paolo >