From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:53468) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ri7rn-0003pP-Cy for qemu-devel@nongnu.org; Tue, 03 Jan 2012 12:09:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ri7ri-0006xF-39 for qemu-devel@nongnu.org; Tue, 03 Jan 2012 12:09:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:22499) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ri7rh-0006x5-Qm for qemu-devel@nongnu.org; Tue, 03 Jan 2012 12:09:34 -0500 Message-ID: <4F033645.2030504@redhat.com> Date: Tue, 03 Jan 2012 19:09:25 +0200 From: Avi Kivity MIME-Version: 1.0 References: <4EF9E660.4050502@redhat.com> <4F0335A4.6040606@codemonkey.ws> In-Reply-To: <4F0335A4.6040606@codemonkey.ws> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL][v2] Remove cpu_get_physical_page_desc List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: "Michael S. Tsirkin" , qemu-devel , Stefano Stabellini On 01/03/2012 07:06 PM, Anthony Liguori wrote: > On 12/27/2011 09:38 AM, Avi Kivity wrote: >> Changes since first posting: fold a fixup patch into its parent patch, >> style fixes. >> >> I didn't get much review or testing for vhost or Xen, due to various >> issues around births separated by a large amount of time if not >> distance, but I don't want to get this series to get stale. Given tha= t >> both are rather niche I think we can fix any issues in tree. >> >> Michael did suggest making changes to vhost, but I prefer that he make= s >> them as he knows how to test. >> >> Please pull from >> >> git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/page_desc >> >> >> v2: fix build (and runtime) breakage in virtio_balloon. > > There's another breakage: > > CC i386-softmmu/xen-all.o > cc1: warnings being treated as errors > /home/anthony/git/qemu/xen-all.c: In function =E2=80=98xen_set_memory=E2= =80=99: > /home/anthony/git/qemu/xen-all.c:376:32: error: passing argument 4 of > =E2=80=98xen_add_to_physmap=E2=80=99 makes integer from pointer without= a cast > /home/anthony/git/qemu/xen-all.c:333:12: note: expected > =E2=80=98target_phys_addr_t=E2=80=99 but argument is of type =E2=80=98s= truct MemoryRegion *=E2=80=99 > /home/anthony/git/qemu/xen-all.c:376:32: error: too many arguments to > function =E2=80=98xen_add_to_physmap=E2=80=99 > /home/anthony/git/qemu/xen-all.c:333:12: note: declared here > make[1]: *** [xen-all.o] Error 1 > make: *** [subdir-i386-softmmu] Error 2 > Sorry about that - will fix asap. (strange, I was 100% sure I tested Xen). --=20 error compiling committee.c: too many arguments to function