From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:46009) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RiQun-0006vQ-Or for qemu-devel@nongnu.org; Wed, 04 Jan 2012 08:30:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RiQuj-0002ey-M9 for qemu-devel@nongnu.org; Wed, 04 Jan 2012 08:30:01 -0500 Received: from mx1.redhat.com ([209.132.183.28]:14687) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RiQuj-0002es-Dr for qemu-devel@nongnu.org; Wed, 04 Jan 2012 08:29:57 -0500 Message-ID: <4F045429.8020503@redhat.com> Date: Wed, 04 Jan 2012 15:29:13 +0200 From: Orit Wasserman MIME-Version: 1.0 References: <1325604879-15862-1-git-send-email-owasserm@redhat.com> <1325604879-15862-6-git-send-email-owasserm@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 5/9] Add XBRLE to ram_save_block and ram_save_live List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: blauwirbel@gmail.com, qemu-devel@nongnu.org, quintela@redhat.com On 01/04/2012 02:14 PM, Stefan Hajnoczi wrote: > On Tue, Jan 3, 2012 at 3:34 PM, Orit Wasserman wrote: >> + /* XOR encoding */ >> + xor_buf = (uint8_t *) g_malloc0(TARGET_PAGE_SIZE); > > Is this an old version of the code? I remember pointing out all the > useless zeroing in a previous revision. If the next line is going to > memcpy or overwrite the entire buffer, please don't zero it first - > especially when the buffer isn't just a small struct. I will fix it > > Stefan