From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:54450) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RiRWM-0007tf-Hg for qemu-devel@nongnu.org; Wed, 04 Jan 2012 09:08:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RiRWI-000188-6F for qemu-devel@nongnu.org; Wed, 04 Jan 2012 09:08:50 -0500 Received: from cantor2.suse.de ([195.135.220.15]:44257 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RiRWI-00017x-1b for qemu-devel@nongnu.org; Wed, 04 Jan 2012 09:08:46 -0500 Message-ID: <4F045D10.9090008@suse.de> Date: Wed, 04 Jan 2012 15:07:12 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1325551939-24749-1-git-send-email-aliguori@us.ibm.com> <1325551939-24749-15-git-send-email-aliguori@us.ibm.com> In-Reply-To: <1325551939-24749-15-git-send-email-aliguori@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 14/30] qdev: prepare source tree for code conversion List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori , malc Cc: Paolo Bonzini , qemu-devel@nongnu.org, Markus Armbruster Am 03.01.2012 01:52, schrieb Anthony Liguori: > These are various small stylistic changes which help make things more > consistent such that the automated conversion script can be simpler. >=20 > It's not necessary to agree or disagree with these style changes becaus= e all > of this code is going to be rewritten by the patch monkey script anyway= . >=20 > Signed-off-by: Anthony Liguori > --- > diff --git a/hw/es1370.c b/hw/es1370.c > index 6a3ba55..3527eb6 100644 > --- a/hw/es1370.c > +++ b/hw/es1370.c > @@ -1041,13 +1041,8 @@ static PCIDeviceInfo es1370_info =3D { > .vendor_id =3D PCI_VENDOR_ID_ENSONIQ, > .device_id =3D PCI_DEVICE_ID_ENSONIQ_ES1370, > .class_id =3D PCI_CLASS_MULTIMEDIA_AUDIO, > -#if 1 > .subsystem_vendor_id =3D 0x4942, > .subsystem_id =3D 0x4c4c, > -#else > - .subsystem_vendor_id =3D 0x1274, > - .subsystem_id =3D 0x1371, > -#endif > }; > =20 > static void es1370_register (void) It is worth noting that this is *not* a stylistic change but actually dropping device information from the tree. malc, what is the meaning of the currently unused values? Would it make sense to move them to a separate PCIDeviceInfo so that they survive the QOM introduction? Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg