From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:58243) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RiRlm-0007Wm-9j for qemu-devel@nongnu.org; Wed, 04 Jan 2012 09:24:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RiRlh-0003lp-5S for qemu-devel@nongnu.org; Wed, 04 Jan 2012 09:24:46 -0500 Received: from mail-tul01m020-f173.google.com ([209.85.214.173]:44269) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RiRlh-0003lc-1t for qemu-devel@nongnu.org; Wed, 04 Jan 2012 09:24:41 -0500 Received: by obcwp18 with SMTP id wp18so15264627obc.4 for ; Wed, 04 Jan 2012 06:24:39 -0800 (PST) Message-ID: <4F046122.50606@codemonkey.ws> Date: Wed, 04 Jan 2012 08:24:34 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1325551939-24749-1-git-send-email-aliguori@us.ibm.com> <1325551939-24749-15-git-send-email-aliguori@us.ibm.com> <4F045D10.9090008@suse.de> In-Reply-To: <4F045D10.9090008@suse.de> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 14/30] qdev: prepare source tree for code conversion List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= Cc: Paolo Bonzini , Anthony Liguori , qemu-devel@nongnu.org, Markus Armbruster On 01/04/2012 08:07 AM, Andreas Färber wrote: > Am 03.01.2012 01:52, schrieb Anthony Liguori: >> These are various small stylistic changes which help make things more >> consistent such that the automated conversion script can be simpler. >> >> It's not necessary to agree or disagree with these style changes because all >> of this code is going to be rewritten by the patch monkey script anyway. >> >> Signed-off-by: Anthony Liguori >> --- > >> diff --git a/hw/es1370.c b/hw/es1370.c >> index 6a3ba55..3527eb6 100644 >> --- a/hw/es1370.c >> +++ b/hw/es1370.c >> @@ -1041,13 +1041,8 @@ static PCIDeviceInfo es1370_info = { >> .vendor_id = PCI_VENDOR_ID_ENSONIQ, >> .device_id = PCI_DEVICE_ID_ENSONIQ_ES1370, >> .class_id = PCI_CLASS_MULTIMEDIA_AUDIO, >> -#if 1 >> .subsystem_vendor_id = 0x4942, >> .subsystem_id = 0x4c4c, >> -#else >> - .subsystem_vendor_id = 0x1274, >> - .subsystem_id = 0x1371, >> -#endif >> }; >> >> static void es1370_register (void) > > It is worth noting that this is *not* a stylistic change but actually > dropping device information from the tree. The #else clause is dead code. It continues to remain in git history but it doesn't serve any purpose in it's current form (it does not affect the build whatsoever). > > malc, what is the meaning of the currently unused values? Would it make > sense to move them to a separate PCIDeviceInfo so that they survive the > QOM introduction? FWIW, I'm fairly sure you can set subsystem vendor and device id via qdev properties so you can always override to these values if you want. Regards, Anthony Liguori > Andreas >