From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:34524) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RiWv5-00069J-7X for qemu-devel@nongnu.org; Wed, 04 Jan 2012 14:54:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RiWv4-0007Oy-BC for qemu-devel@nongnu.org; Wed, 04 Jan 2012 14:54:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38638) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RiWv4-0007Os-0S for qemu-devel@nongnu.org; Wed, 04 Jan 2012 14:54:42 -0500 Message-ID: <4F04AE7D.50109@redhat.com> Date: Wed, 04 Jan 2012 21:54:37 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1325705558-24358-1-git-send-email-avi@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Rename target_phys_addr_t to Phys List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org On 01/04/2012 09:50 PM, Peter Maydell wrote: > On 4 January 2012 19:32, Avi Kivity wrote: > > The name 'Phys' conveys exactly the same information as 'target_phys_addr_t': > > > > - it has to be a physical address (no such thing as physical data) > > - it has to be a target address (qemu doesn't do host physical addresses) > > - the fact that it's a type is implied by the naming convention > > > > As it's 4 characters vs. 18, and C standard compliant to boot, Phys is a > > clear winner. Rename all instances of target_phys_addr_t to the new name. > > All hail Phys! > > > > 323 files changed, 1959 insertions(+), 1959 deletions(-) > > Seems like gratuitous churn to me... > It will generate noise, but improve readability by a little bit. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.