From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:59565) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rib0C-0003kz-JP for qemu-devel@nongnu.org; Wed, 04 Jan 2012 19:16:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rib0B-0003Hu-I5 for qemu-devel@nongnu.org; Wed, 04 Jan 2012 19:16:16 -0500 Received: from mail-gx0-f173.google.com ([209.85.161.173]:61324) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rib0B-0003Hp-EJ for qemu-devel@nongnu.org; Wed, 04 Jan 2012 19:16:15 -0500 Received: by ggnk1 with SMTP id k1so12579288ggn.4 for ; Wed, 04 Jan 2012 16:16:14 -0800 (PST) Message-ID: <4F04EBCB.6030501@codemonkey.ws> Date: Wed, 04 Jan 2012 18:16:11 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1325705558-24358-1-git-send-email-avi@redhat.com> <4F04CE13.3030005@codemonkey.ws> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Rename target_phys_addr_t to Phys List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Avi Kivity , qemu-devel@nongnu.org On 01/04/2012 05:33 PM, Peter Maydell wrote: > On 4 January 2012 22:09, Anthony Liguori wrote: >> target_phys_addr_t should exist IMHO in the device model code. > > (I assume "should not" ?) Yes, sorry. > >> I think it >> would be more useful to introduce a hw_addr, fix it at u64, make the device >> model and memory API use that, and then make it so we didn't do the >> silliness around libhw32/libhw64. > > A lot of the usage of target_phys_addr_t in hw/ is actually not > handling addresses at all, but merely offsets into device IO regions > (ie as parameters to device read/write functions)... Exactly, which is why using target_phys_addr_t (and subsequently building the device twice) doesn't make a lot of sense. Regards, Anthony Liguori > > -- PMM >