From: Gerd Hoffmann <kraxel@redhat.com>
To: Andriy Gapon <avg@FreeBSD.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] usb-ohci: td.cbp incorrectly updated near page end
Date: Fri, 06 Jan 2012 10:47:06 +0100 [thread overview]
Message-ID: <4F06C31A.90700@redhat.com> (raw)
In-Reply-To: <4EF2F9A6.3020601@FreeBSD.org>
On 12/22/11 10:34, Andriy Gapon wrote:
> The current code that updates the cbp value after a transfer looks like this:
> td.cbp += ret;
> if ((td.cbp & 0xfff) + ret > 0xfff) {
> <handle page overflow>
> because the 'ret' value is effectively added twice the check may fire too early
> when the overflow hasn't happened yet.
Patch added to usb patch queue.
thanks,
Gerd
prev parent reply other threads:[~2012-01-06 9:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-22 9:34 [Qemu-devel] usb-ohci: td.cbp incorrectly updated near page end Andriy Gapon
2011-12-30 11:07 ` Stefan Hajnoczi
2012-01-06 9:47 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F06C31A.90700@redhat.com \
--to=kraxel@redhat.com \
--cc=avg@FreeBSD.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).