From: Gerd Hoffmann <kraxel@redhat.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/5] usb-redir: Dynamically adjust iso buffering size based on ep interval
Date: Fri, 06 Jan 2012 10:51:27 +0100 [thread overview]
Message-ID: <4F06C41F.3040103@redhat.com> (raw)
In-Reply-To: <1324552358-5234-2-git-send-email-hdegoede@redhat.com>
On 12/22/11 12:12, Hans de Goede wrote:
> Note the bufpq_target_size id stored in the endpoint info struct,
> even though it only used once. This is done because it will be
> referenced from other code in a follow up patch.
=== checkpatch complains ===
WARNING: braces {} are necessary for all arms of this statement
#29: FILE: usb-redir.c:343:
+ if (dev->dev.speed == USB_SPEED_HIGH)
[...]
+ else
[...]
total: 0 errors, 1 warnings, 77 lines checked
cheers,
Gerd
Hint:
http://blog.vmsplice.net/2011/03/how-to-automatically-run-checkpatchpl.html
next prev parent reply other threads:[~2012-01-06 9:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-22 11:12 [Qemu-devel] [PATCH 1/5] usb-redir: Clear iso / irq error when stopping the stream Hans de Goede
2011-12-22 11:12 ` [Qemu-devel] [PATCH 2/5] usb-redir: Dynamically adjust iso buffering size based on ep interval Hans de Goede
2012-01-06 9:51 ` Gerd Hoffmann [this message]
2011-12-22 11:12 ` [Qemu-devel] [PATCH 3/5] usb-redir: Pre-fill our isoc input buffer before sending pkts to the host Hans de Goede
2011-12-22 11:12 ` [Qemu-devel] [PATCH 4/5] usb-redir: Try to keep our buffer size near the target size Hans de Goede
2011-12-22 11:12 ` [Qemu-devel] [PATCH 5/5] usb-redir: Improve some debugging messages Hans de Goede
-- strict thread matches above, loose matches on Subject: below --
2012-01-10 13:13 [Qemu-devel] [PATCH 1/5] usb-redir: Clear iso / irq error when stopping the stream Hans de Goede
2012-01-10 13:13 ` [Qemu-devel] [PATCH 2/5] usb-redir: Dynamically adjust iso buffering size based on ep interval Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F06C41F.3040103@redhat.com \
--to=kraxel@redhat.com \
--cc=hdegoede@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).