From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:53497) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rj6SU-0008Fs-63 for qemu-devel@nongnu.org; Fri, 06 Jan 2012 04:51:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rj6ST-00075A-30 for qemu-devel@nongnu.org; Fri, 06 Jan 2012 04:51:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40095) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rj6SS-000754-P7 for qemu-devel@nongnu.org; Fri, 06 Jan 2012 04:51:33 -0500 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q069pVOx001055 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 6 Jan 2012 04:51:31 -0500 Message-ID: <4F06C41F.3040103@redhat.com> Date: Fri, 06 Jan 2012 10:51:27 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <1324552358-5234-1-git-send-email-hdegoede@redhat.com> <1324552358-5234-2-git-send-email-hdegoede@redhat.com> In-Reply-To: <1324552358-5234-2-git-send-email-hdegoede@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/5] usb-redir: Dynamically adjust iso buffering size based on ep interval List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hans de Goede Cc: qemu-devel@nongnu.org On 12/22/11 12:12, Hans de Goede wrote: > Note the bufpq_target_size id stored in the endpoint info struct, > even though it only used once. This is done because it will be > referenced from other code in a follow up patch. === checkpatch complains === WARNING: braces {} are necessary for all arms of this statement #29: FILE: usb-redir.c:343: + if (dev->dev.speed == USB_SPEED_HIGH) [...] + else [...] total: 0 errors, 1 warnings, 77 lines checked cheers, Gerd Hint: http://blog.vmsplice.net/2011/03/how-to-automatically-run-checkpatchpl.html