From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:43026)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1Rj8lz-0006qq-3m
	for qemu-devel@nongnu.org; Fri, 06 Jan 2012 07:19:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1Rj8ly-0005Cs-6C
	for qemu-devel@nongnu.org; Fri, 06 Jan 2012 07:19:51 -0500
Received: from mx1.redhat.com ([209.132.183.28]:31930)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1Rj8lx-0005Co-Sc
	for qemu-devel@nongnu.org; Fri, 06 Jan 2012 07:19:50 -0500
Message-ID: <4F06E6C6.5080607@redhat.com>
Date: Fri, 06 Jan 2012 14:19:18 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1323467645-24271-1-git-send-email-anthony.perard@citrix.com>
	<1323467645-24271-6-git-send-email-anthony.perard@citrix.com>
	<4EE3382D.80903@web.de>
	<alpine.DEB.2.00.1112121259180.3517@kaball-desktop>
	<4EE609BF.1070307@siemens.com>
	<alpine.DEB.2.00.1112121438410.3517@kaball-desktop>
	<4EE617BA.4030102@siemens.com>
	<alpine.DEB.2.00.1112121527130.3517@kaball-desktop>
	<4EEE25DA.2080400@redhat.com>
	<alpine.DEB.2.00.1201041618390.3150@kaball-desktop>
	<4F048B10.1060505@redhat.com>
	<alpine.DEB.2.00.1201051134150.3150@kaball-desktop>
	<4F059C8C.2030303@redhat.com>
	<alpine.DEB.2.00.1201051303350.3150@kaball-desktop>
	<4F05A684.7000509@redhat.com>
	<alpine.DEB.2.00.1201051427340.3150@kaball-desktop>
	<4F05BF9E.7000203@redhat.com>
	<alpine.DEB.2.00.1201051536290.3150@kaball-desktop>
	<4F05D0BC.70707@redhat.com>
	<alpine.DEB.2.00.1201051646580.3150@kaball-desktop>
	<4F05E301.2020808@redhat.com> <4F05F09E.8030800@web.de>
In-Reply-To: <4F05F09E.8030800@web.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V2 5/5] vga-cirrus: Workaround during
 restore when using Xen.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Anthony Perard <anthony.perard@citrix.com>, Xen Devel <xen-devel@lists.xensource.com>, QEMU-devel <qemu-devel@nongnu.org>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>

On 01/05/2012 08:49 PM, Jan Kiszka wrote:
> To me this still sounds like a cirrus-only xen workaround that
> nevertheless spreads widely.

It is.

> Again, what speaks against migrating the information Xen needs before
> creating the machine or a single device? That would only introduce a
> generic concept of an (optional) "early", let's call it
> "accelerator-related" vmstate and would allow Xen to deal with all the
> specifics behind the curtain.
>

Adding more concepts, just to work around a bug (and this is really a
bug in the qemu/xen interface) makes it harder to refactor things later on.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.