From: Jan Kiszka <jan.kiszka@web.de>
To: "Zhang, Yang Z" <yang.z.zhang@intel.com>
Cc: "aliguori@us.ibm.com" <aliguori@us.ibm.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"Shan, Haitao" <haitao.shan@intel.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"avi@redhat.com" <avi@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/3] stop the periodic RTC update timer
Date: Fri, 06 Jan 2012 15:26:37 -0200 [thread overview]
Message-ID: <4F072ECD.6000402@web.de> (raw)
In-Reply-To: <A9667DDFB95DB7438FA9D7D576C3D87E018CDB@SHSMSX101.ccr.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 908 bytes --]
On 2012-01-06 05:37, Zhang, Yang Z wrote:
> change the RTC update logic to use host time with offset to calculate RTC clock.
> There have no need to use two periodic timers to maintain an internal timer for RTC clock update and alarm check. Instead, we calculate the real RTC time by the host time with an offset. For alarm and updated-end interrupt, if guest enabled it, then we setup a timer, or else, stop it.
>
> Signed-off-by: Yang Zhang <yang.z.zhang@intel.com>
I appreciate this effort!
However, not having looked at details yet, two things jumped at me:
- You cannot simply change the vmstate format without caring about
migration from older qemu versions. Ideally, if possible the existing
format is kept and translated to new internal representations on
save/load.
- Please respect the coding style. It's documented, and we also have a
checker.
Thanks,
Jab
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
next prev parent reply other threads:[~2012-01-06 17:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-06 7:37 [Qemu-devel] [PATCH 3/3] stop the periodic RTC update timer Zhang, Yang Z
2012-01-06 17:26 ` Jan Kiszka [this message]
2012-01-09 7:10 ` Zhang, Yang Z
2012-01-09 8:19 ` Paolo Bonzini
2012-01-10 6:37 ` Zhang, Yang Z
2012-01-10 9:24 ` Paolo Bonzini
2012-01-11 0:56 ` Zhang, Yang Z
2012-01-11 7:24 ` Paolo Bonzini
2012-01-12 0:51 ` Zhang, Yang Z
2012-01-11 7:25 ` Philipp Hahn
2012-01-11 13:10 ` Marcelo Tosatti
2012-01-12 0:00 ` Zhang, Yang Z
2012-01-12 9:26 ` Paolo Bonzini
2012-01-12 10:20 ` Marcelo Tosatti
2012-01-12 10:43 ` Paolo Bonzini
2012-01-12 9:59 ` Marcelo Tosatti
2012-01-12 10:03 ` Marcelo Tosatti
2012-01-12 10:12 ` Zhang, Yang Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F072ECD.6000402@web.de \
--to=jan.kiszka@web.de \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=haitao.shan@intel.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).