From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:39470) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RjDZA-0004sA-9E for qemu-devel@nongnu.org; Fri, 06 Jan 2012 12:26:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RjDZ8-0007Uf-UO for qemu-devel@nongnu.org; Fri, 06 Jan 2012 12:26:56 -0500 Received: from fmmailgate01.web.de ([217.72.192.221]:38782) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RjDZ8-0007UU-MN for qemu-devel@nongnu.org; Fri, 06 Jan 2012 12:26:54 -0500 Received: from moweb001.kundenserver.de (moweb001.kundenserver.de [172.19.20.114]) by fmmailgate01.web.de (Postfix) with ESMTP id 8CA711A86FC05 for ; Fri, 6 Jan 2012 18:26:53 +0100 (CET) Message-ID: <4F072ECD.6000402@web.de> Date: Fri, 06 Jan 2012 15:26:37 -0200 From: Jan Kiszka MIME-Version: 1.0 References: In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigEFF376C0D62E979269C68BB0" Subject: Re: [Qemu-devel] [PATCH 3/3] stop the periodic RTC update timer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Zhang, Yang Z" Cc: "aliguori@us.ibm.com" , "kvm@vger.kernel.org" , "Shan, Haitao" , "qemu-devel@nongnu.org" , "avi@redhat.com" This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigEFF376C0D62E979269C68BB0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2012-01-06 05:37, Zhang, Yang Z wrote: > change the RTC update logic to use host time with offset to calculate R= TC clock. > There have no need to use two periodic timers to maintain an internal = timer for RTC clock update and alarm check. Instead, we calculate the rea= l RTC time by the host time with an offset. For alarm and updated-end int= errupt, if guest enabled it, then we setup a timer, or else, stop it. >=20 > Signed-off-by: Yang Zhang I appreciate this effort! However, not having looked at details yet, two things jumped at me: - You cannot simply change the vmstate format without caring about migration from older qemu versions. Ideally, if possible the existing format is kept and translated to new internal representations on save/load. - Please respect the coding style. It's documented, and we also have a checker. Thanks, Jab --------------enigEFF376C0D62E979269C68BB0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk8HLtMACgkQitSsb3rl5xTzKACfXwMC1jmP3xlcfVBwaP2Jf5Qg GTgAoIn9aS5tcX54ZfjkKjlkbtoDQGl/ =gchr -----END PGP SIGNATURE----- --------------enigEFF376C0D62E979269C68BB0--