From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:46732)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <i.mitsyanko@gmail.com>) id 1RjFBO-00060V-4F
	for qemu-devel@nongnu.org; Fri, 06 Jan 2012 14:10:30 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <i.mitsyanko@gmail.com>) id 1RjFBL-0006xg-EC
	for qemu-devel@nongnu.org; Fri, 06 Jan 2012 14:10:30 -0500
Received: from mail-ey0-f173.google.com ([209.85.215.173]:34470)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <i.mitsyanko@gmail.com>) id 1RjFBL-0006xE-7a
	for qemu-devel@nongnu.org; Fri, 06 Jan 2012 14:10:27 -0500
Received: by eaad1 with SMTP id d1so1209130eaa.4
	for <qemu-devel@nongnu.org>; Fri, 06 Jan 2012 11:10:26 -0800 (PST)
Message-ID: <4F074721.8050403@gmail.com>
Date: Fri, 06 Jan 2012 23:10:25 +0400
From: Igor Mitsyanko <i.mitsyanko@gmail.com>
MIME-Version: 1.0
References: <1325793761-10249-1-git-send-email-mark.langsdorf@calxeda.com>	<1325793761-10249-6-git-send-email-mark.langsdorf@calxeda.com>	<4F073F5E.6090507@gmail.com>
	<CAFEAcA9czTONTKp8J51EQNKQmi+qu9QtYDEwTwAN4V1fy8w=rA@mail.gmail.com>
In-Reply-To: <CAFEAcA9czTONTKp8J51EQNKQmi+qu9QtYDEwTwAN4V1fy8w=rA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 5/5] arm: SoC model for Calxeda Highbank
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Mark Langsdorf <mark.langsdorf@calxeda.com>, qemu-devel@nongnu.org, Rob Herring <rob.herring@calxeda.com>, afaerber@suse.de

On 01/06/2012 10:45 PM, Peter Maydell wrote:
> On 6 January 2012 18:37, Igor Mitsyanko<i.mitsyanko@gmail.com>  wrote:
>> On 01/06/2012 12:02 AM, Mark Langsdorf wrote:
>>> +    if (!cpu_model) {
>>> +        cpu_model = "cortex-a9";
>>> +    }
>>
>>
>> Google said there is only cortexA9-based Highbank SoC version, maybe you
>> should just hardcode cpu model?
>
> This is just boilerplate code for any random ARM board at the moment:
> it defaults the CPU but lets the user override. We should either make
> a decision to do something else for all boards, or follow the usual
> convention here; I'm happy to do the latter.
>

Are you saying that it's a mistake that we hardcoded cpu model and 
memory size for Exynos boards in our patches? It makes sense to use 
documented values in emulation, many boards in qemu currently do this. 
And probably nothing even going to work with wrong cpu model, I though 
this command line option is mostly for x86 target.