* [Qemu-devel] [PATCH] virtio-9p-proxy: Fix typo causing compile failure on 32 bit hosts
@ 2012-01-06 18:47 Peter Maydell
2012-01-06 19:11 ` Anthony Liguori
0 siblings, 1 reply; 2+ messages in thread
From: Peter Maydell @ 2012-01-06 18:47 UTC (permalink / raw)
To: qemu-devel; +Cc: Anthony Liguori, M. Mohan Kumar, Aneesh Kumar K.V, patches
Fix a compile failure on 32 bit hosts (integer constant is too large
for 'unsigned long' type) by correcting a typo where the mask used
for filling in the second f_fsid word had too many 'F's in it.
Also drop the 'L' suffix that allowed this typo to go undetected on
64 bit hosts.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
This was introduced in commit b178adc3e.
hw/9pfs/virtio-9p-proxy.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/9pfs/virtio-9p-proxy.c b/hw/9pfs/virtio-9p-proxy.c
index 44f5fc4..d5ad208 100644
--- a/hw/9pfs/virtio-9p-proxy.c
+++ b/hw/9pfs/virtio-9p-proxy.c
@@ -112,8 +112,8 @@ static void prstatfs_to_statfs(struct statfs *stfs, ProxyStatFS *prstfs)
stfs->f_bavail = prstfs->f_bavail;
stfs->f_files = prstfs->f_files;
stfs->f_ffree = prstfs->f_ffree;
- stfs->f_fsid.__val[0] = prstfs->f_fsid[0] & 0xFFFFFFFFUL;
- stfs->f_fsid.__val[1] = prstfs->f_fsid[1] >> 32 & 0xFFFFFFFFFUL;
+ stfs->f_fsid.__val[0] = prstfs->f_fsid[0] & 0xFFFFFFFFU;
+ stfs->f_fsid.__val[1] = prstfs->f_fsid[1] >> 32 & 0xFFFFFFFFU;
stfs->f_namelen = prstfs->f_namelen;
stfs->f_frsize = prstfs->f_frsize;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] virtio-9p-proxy: Fix typo causing compile failure on 32 bit hosts
2012-01-06 18:47 [Qemu-devel] [PATCH] virtio-9p-proxy: Fix typo causing compile failure on 32 bit hosts Peter Maydell
@ 2012-01-06 19:11 ` Anthony Liguori
0 siblings, 0 replies; 2+ messages in thread
From: Anthony Liguori @ 2012-01-06 19:11 UTC (permalink / raw)
To: Peter Maydell
Cc: Anthony Liguori, M. Mohan Kumar, qemu-devel, patches,
Aneesh Kumar K.V
On 01/06/2012 12:47 PM, Peter Maydell wrote:
> Fix a compile failure on 32 bit hosts (integer constant is too large
> for 'unsigned long' type) by correcting a typo where the mask used
> for filling in the second f_fsid word had too many 'F's in it.
> Also drop the 'L' suffix that allowed this typo to go undetected on
> 64 bit hosts.
>
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
> This was introduced in commit b178adc3e.
>
> hw/9pfs/virtio-9p-proxy.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/9pfs/virtio-9p-proxy.c b/hw/9pfs/virtio-9p-proxy.c
> index 44f5fc4..d5ad208 100644
> --- a/hw/9pfs/virtio-9p-proxy.c
> +++ b/hw/9pfs/virtio-9p-proxy.c
> @@ -112,8 +112,8 @@ static void prstatfs_to_statfs(struct statfs *stfs, ProxyStatFS *prstfs)
> stfs->f_bavail = prstfs->f_bavail;
> stfs->f_files = prstfs->f_files;
> stfs->f_ffree = prstfs->f_ffree;
> - stfs->f_fsid.__val[0] = prstfs->f_fsid[0]& 0xFFFFFFFFUL;
> - stfs->f_fsid.__val[1] = prstfs->f_fsid[1]>> 32& 0xFFFFFFFFFUL;
> + stfs->f_fsid.__val[0] = prstfs->f_fsid[0]& 0xFFFFFFFFU;
> + stfs->f_fsid.__val[1] = prstfs->f_fsid[1]>> 32& 0xFFFFFFFFU;
> stfs->f_namelen = prstfs->f_namelen;
> stfs->f_frsize = prstfs->f_frsize;
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-01-06 19:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-06 18:47 [Qemu-devel] [PATCH] virtio-9p-proxy: Fix typo causing compile failure on 32 bit hosts Peter Maydell
2012-01-06 19:11 ` Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).