From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:46903) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RjFC4-0006fP-I9 for qemu-devel@nongnu.org; Fri, 06 Jan 2012 14:11:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RjFC3-00075R-7o for qemu-devel@nongnu.org; Fri, 06 Jan 2012 14:11:12 -0500 Received: from mail-tul01m020-f173.google.com ([209.85.214.173]:36486) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RjFC3-00075N-2E for qemu-devel@nongnu.org; Fri, 06 Jan 2012 14:11:11 -0500 Received: by obcwp18 with SMTP id wp18so2473149obc.4 for ; Fri, 06 Jan 2012 11:11:10 -0800 (PST) Message-ID: <4F074749.1000009@codemonkey.ws> Date: Fri, 06 Jan 2012 13:11:05 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1325875641-27938-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1325875641-27938-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] virtio-9p-proxy: Fix typo causing compile failure on 32 bit hosts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Anthony Liguori , "M. Mohan Kumar" , qemu-devel@nongnu.org, patches@linaro.org, "Aneesh Kumar K.V" On 01/06/2012 12:47 PM, Peter Maydell wrote: > Fix a compile failure on 32 bit hosts (integer constant is too large > for 'unsigned long' type) by correcting a typo where the mask used > for filling in the second f_fsid word had too many 'F's in it. > Also drop the 'L' suffix that allowed this typo to go undetected on > 64 bit hosts. > > Signed-off-by: Peter Maydell Applied. Thanks. Regards, Anthony Liguori > --- > This was introduced in commit b178adc3e. > > hw/9pfs/virtio-9p-proxy.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/9pfs/virtio-9p-proxy.c b/hw/9pfs/virtio-9p-proxy.c > index 44f5fc4..d5ad208 100644 > --- a/hw/9pfs/virtio-9p-proxy.c > +++ b/hw/9pfs/virtio-9p-proxy.c > @@ -112,8 +112,8 @@ static void prstatfs_to_statfs(struct statfs *stfs, ProxyStatFS *prstfs) > stfs->f_bavail = prstfs->f_bavail; > stfs->f_files = prstfs->f_files; > stfs->f_ffree = prstfs->f_ffree; > - stfs->f_fsid.__val[0] = prstfs->f_fsid[0]& 0xFFFFFFFFUL; > - stfs->f_fsid.__val[1] = prstfs->f_fsid[1]>> 32& 0xFFFFFFFFFUL; > + stfs->f_fsid.__val[0] = prstfs->f_fsid[0]& 0xFFFFFFFFU; > + stfs->f_fsid.__val[1] = prstfs->f_fsid[1]>> 32& 0xFFFFFFFFU; > stfs->f_namelen = prstfs->f_namelen; > stfs->f_frsize = prstfs->f_frsize; > }