From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:39688) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RjG9i-0001il-AO for qemu-devel@nongnu.org; Fri, 06 Jan 2012 15:12:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RjG9g-0008Px-Rs for qemu-devel@nongnu.org; Fri, 06 Jan 2012 15:12:50 -0500 Received: from cantor2.suse.de ([195.135.220.15]:60581 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RjG9g-0008Ps-NH for qemu-devel@nongnu.org; Fri, 06 Jan 2012 15:12:48 -0500 Message-ID: <4F075565.3040408@suse.de> Date: Fri, 06 Jan 2012 21:11:17 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1325793761-10249-1-git-send-email-mark.langsdorf@calxeda.com> <1325793761-10249-6-git-send-email-mark.langsdorf@calxeda.com> <4F073F5E.6090507@gmail.com> <4F074721.8050403@gmail.com> In-Reply-To: <4F074721.8050403@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 5/5] arm: SoC model for Calxeda Highbank List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mitsyanko , Peter Maydell Cc: Mark Langsdorf , qemu-devel@nongnu.org, Rob Herring Am 06.01.2012 20:10, schrieb Igor Mitsyanko: > On 01/06/2012 10:45 PM, Peter Maydell wrote: >> On 6 January 2012 18:37, Igor Mitsyanko wrote: >>> On 01/06/2012 12:02 AM, Mark Langsdorf wrote: >>>> + if (!cpu_model) { >>>> + cpu_model =3D "cortex-a9"; >>>> + } >>> >>> >>> Google said there is only cortexA9-based Highbank SoC version, maybe = you >>> should just hardcode cpu model? >> >> This is just boilerplate code for any random ARM board at the moment: >> it defaults the CPU but lets the user override. We should either make >> a decision to do something else for all boards, or follow the usual >> convention here; I'm happy to do the latter. >> >=20 > Are you saying that it's a mistake that we hardcoded cpu model and > memory size for Exynos boards in our patches? No machine should silently change the user's -cpu to something else. Either error out or warn the user, or let them face the consequences of their parameters themselves. Not sure how hardcoding the cpu_model would work with CPU features, would they be still included or stripped out before. Peter? Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg