Re: [Qemu-devel] [PATCH 13/16] Direct dispatch through MemoryRegion

["Andreas Färber" <afaerber@suse.de>]

Am 02.01.2012 17:33, schrieb Avi Kivity:
> Now that all mmio goes through MemoryRegions, we can convert
> io_mem_opaque to be a MemoryRegion pointer, and remove the thunks
> that convert from old-style CPU{Read,Write}MemoryFunc to MemoryRegionOps.
> 
> Signed-off-by: Avi Kivity <avi@redhat.com>

> diff --git a/memory.c b/memory.c
> index e34bc65..25b36ff 100644
> --- a/memory.c
> +++ b/memory.c

> +static void adjust_endianness(MemoryRegion *mr, uint64_t *data, unsigned size)
>  {
> -    MemoryRegion *mr = _mr;
> +    if (memory_region_wrong_endianness(mr)) {
> +        switch (size) {
> +        case 1:
> +            break;
> +        case 2:
> +            *data = bswap16(*data);
> +            break;
> +        case 4:
> +            *data = bswap32(*data);

break; missing. Patch coming up.

Andreas

> +        default:
> +            abort();
> +        }
> +    }
> +}

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg