From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:59843)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RjR9B-00007x-JO
	for qemu-devel@nongnu.org; Sat, 07 Jan 2012 02:57:02 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RjR9A-0006gi-9m
	for qemu-devel@nongnu.org; Sat, 07 Jan 2012 02:57:01 -0500
Received: from cantor2.suse.de ([195.135.220.15]:54395 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RjR9A-0006gP-3M
	for qemu-devel@nongnu.org; Sat, 07 Jan 2012 02:57:00 -0500
Message-ID: <4F07FA71.8010105@suse.de>
Date: Sat, 07 Jan 2012 08:55:29 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1325522015-503-1-git-send-email-avi@redhat.com>
	<1325522015-503-14-git-send-email-avi@redhat.com>
In-Reply-To: <1325522015-503-14-git-send-email-avi@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 13/16] Direct dispatch through MemoryRegion
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>

Am 02.01.2012 17:33, schrieb Avi Kivity:
> Now that all mmio goes through MemoryRegions, we can convert
> io_mem_opaque to be a MemoryRegion pointer, and remove the thunks
> that convert from old-style CPU{Read,Write}MemoryFunc to MemoryRegionOp=
s.
>=20
> Signed-off-by: Avi Kivity <avi@redhat.com>

> diff --git a/memory.c b/memory.c
> index e34bc65..25b36ff 100644
> --- a/memory.c
> +++ b/memory.c

> +static void adjust_endianness(MemoryRegion *mr, uint64_t *data, unsign=
ed size)
>  {
> -    MemoryRegion *mr =3D _mr;
> +    if (memory_region_wrong_endianness(mr)) {
> +        switch (size) {
> +        case 1:
> +            break;
> +        case 2:
> +            *data =3D bswap16(*data);
> +            break;
> +        case 4:
> +            *data =3D bswap32(*data);

break; missing. Patch coming up.

Andreas

> +        default:
> +            abort();
> +        }
> +    }
> +}

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg