From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:44643)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1Rjq9y-00086V-Dj
	for qemu-devel@nongnu.org; Sun, 08 Jan 2012 05:39:31 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1Rjq9x-0001nS-Ea
	for qemu-devel@nongnu.org; Sun, 08 Jan 2012 05:39:30 -0500
Received: from mx1.redhat.com ([209.132.183.28]:39880)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1Rjq9x-0001nO-4f
	for qemu-devel@nongnu.org; Sun, 08 Jan 2012 05:39:29 -0500
Message-ID: <4F097253.5080600@redhat.com>
Date: Sun, 08 Jan 2012 12:39:15 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1323467645-24271-1-git-send-email-anthony.perard@citrix.com>
	<4EE3382D.80903@web.de>
	<alpine.DEB.2.00.1112121259180.3517@kaball-desktop>
	<4EE609BF.1070307@siemens.com>
	<alpine.DEB.2.00.1112121438410.3517@kaball-desktop>
	<4EE617BA.4030102@siemens.com>
	<alpine.DEB.2.00.1112121527130.3517@kaball-desktop>
	<4EEE25DA.2080400@redhat.com>
	<alpine.DEB.2.00.1201041618390.3150@kaball-desktop>
	<4F048B10.1060505@redhat.com>
	<alpine.DEB.2.00.1201051134150.3150@kaball-desktop>
	<4F059C8C.2030303@redhat.com>
	<alpine.DEB.2.00.1201051303350.3150@kaball-desktop>
	<4F05A684.7000509@redhat.com>
	<alpine.DEB.2.00.1201051427340.3150@kaball-desktop>
	<4F05BF9E.7000203@redhat.com>
	<alpine.DEB.2.00.1201051536290.3150@kaball-desktop>
	<4F05D0BC.70707@redhat.com>
	<alpine.DEB.2.00.1201051646580.3150@kaball-desktop>
	<4F05E301.2020808@redhat.com> <4F05F09E.8030800@web.de>
	<alpine.DEB.2.00.1201061045550.3150@kaball-desktop>
	<4F06F76F.7090002@web.de>
	<alpine.DEB.2.00.1201061417480.3150@kaball-deskto! p>
In-Reply-To: <alpine.DEB.2.00.1201061417480.3150@kaball-desktop>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V2 5/5] vga-cirrus: Workaround during
 restore when using Xen.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Anthony Perard <anthony.perard@citrix.com>, Xen Devel <xen-devel@lists.xensource.com>, Jan Kiszka <jan.kiszka@web.de>, QEMU-devel <qemu-devel@nongnu.org>

On 01/06/2012 04:40 PM, Stefano Stabellini wrote:
> Avi, if you think that early_savevm is a decent solution, we'll start
> working on it. 

I don't like early_savevm because it complicates life for devices, for
what is a localized problem.  But if everything else is even more
complicated maybe we should do it.

> Also if you would like to save and restore all the
> MemoryRegions because you can see some possible future uses for it, please
> let me know. Otherwise we might try to save some space and just store the
> ones we need.

MemoryRegions don't hold their own state, they just mirror state that
exists elsewhere.  They're 100% implementation artefacts, it's totally
wrong to save/restore them.

-- 
error compiling committee.c: too many arguments to function