Re: [Qemu-devel] [Bug] System emulation with flash broken?

[Avi Kivity <avi@redhat.com>]

On 01/08/2012 02:23 PM, Gerhard Wiesinger wrote:
> On Sun, 8 Jan 2012, Avi Kivity wrote:
>
>> On 01/07/2012 08:03 PM, Gerhard Wiesinger wrote:
>>> On Fri, 6 Jan 2012, Stefan Weil wrote:
>>>
>>>> Hello Avi,
>>>>
>>>> latest QEMU seems to be broken when a system emulation with flash is
>>>> started.
>>>>
>>>> I did not run git bisect, but it looks like the problem started with
>>>> this change:
>>>>
>>>> c5705a7728b4a6bc9e4f2d35911adbaf28042b25
>>>> Author: Avi Kivity <avi@redhat.com>  2011-12-20 14:59:12
>>>> vmstate, memory: decouple vmstate from memory API
>>>>
>>>> I first noticed the problem with my AR7 emulation (not part
>>>> of official QEMU), but also got it with MIPS Malta, so I assume
>>>> that all systems with flash are broken and fail with this assertion:
>>>>
>>>> /qemu/exec.c:2785: qemu_ram_set_idstr: Assertion `new_block' failed.
>>>>
>>>> The function is searching for address 0x10000009 which is 0x10000000
>>>> plus an index. Without the index, the address would have been found.
>>>
>>> Hello Avi,
>>>
>>> I'm having also problems with this patch:
>>> # VGA bank switching problems under DOS
>>> git checkout 682a3c07f0e28d2532c911a44a9b6142d6299cc2
>>>
>>> # OK
>>> git checkout aad3b517a1b83561f2755dc4451596a421399c19
>>>
>>> And commit 682a3c07f0e28d2532c911a44a9b6142d6299cc2 is the Merge
>>> commit 'c5705a7728b4a6bc9e4f2d35911adbaf28042b25' into upstream-merge.
>>>
>>
>> A patch for this has already been posted; hopefully to be merged soon.
>
> To test: Which patch do you exactly mean?
>

Original patch:

  http://article.gmane.org/gmane.comp.emulators.qemu/131082

My alternative:

  http://article.gmane.org/gmane.comp.emulators.qemu/131164

-- 
error compiling committee.c: too many arguments to function