From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:44269) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RjvgE-0004Gw-So for qemu-devel@nongnu.org; Sun, 08 Jan 2012 11:33:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RjvgD-0003dg-LD for qemu-devel@nongnu.org; Sun, 08 Jan 2012 11:33:10 -0500 Message-ID: <4F09C4E9.3010300@suse.de> Date: Sun, 08 Jan 2012 17:31:37 +0100 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <4F0487EE.6090502@suse.de> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] hw/vmmouse.c: Fix to disable vmmouse after reboot List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerhard Wiesinger Cc: qemu-devel@nongnu.org, qemu-stable@nongnu.org Am 08.01.2012 13:01, schrieb Gerhard Wiesinger: > On Wed, 4 Jan 2012, Gerhard Wiesinger wrote: >=20 >> Testscenario: >> 1.) Boot e.g. OS with VMMouse support (e.g. Windows) >> 2.) reboot >> 3.) Boot e.g. OS without VMMouse support (e.g. DOS) =3D> PS/2 mouse >> doesn't work any more. Fixes that issue. >> >> Reason is that VMMouse has priority and disables all other mouse >> entities and therefore must be disabled on reset. >=20 > Any further comments before integrating the patch? I implicitly asked you for a more verbose commit message. For example, based on the info you provided as a reply above: --8<-- hw/vmmouse.c: Disable vmmouse on reboot When a guest activated the vmmouse, following a reboot the vmmouse stayed enabled and the PS/2 mouse was unusable. That way, when rebooting to guests without vmmouse support the mouse would not work. Fix this by disabling the vmmouse in its reset handler. --8<-- I have it queued for testing tomorrow - I am hoping this will fix a 0.15.1 mouse issue after kdump as well. As a bugfix, it would definitely be a candidate for stable-1.0. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg