qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Gerhard Wiesinger <lists@wiesinger.com>
Cc: Kevin O'Connor <kevin@koconnor.net>,
	qemu-devel@nongnu.org, Gleb Natapov <gleb@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] network: Added option to disable NIC option roms
Date: Mon, 09 Jan 2012 10:15:15 +0100	[thread overview]
Message-ID: <4F0AB023.5040705@redhat.com> (raw)
In-Reply-To: <alpine.LFD.2.02.1201081253310.14379@bbs.intern>

  Hi,

>      if (!pci_dev->qdev.hotplugged) {
>          static int loaded = 0;
> -        if (!loaded) {
> +        if (!loaded &&
> pci_has_not_explicitly_disabled_option_romfile(pci_dev)) {
>              rom_add_option("pxe-ne2k_pci.rom", -1);
>              loaded = 1;
>          }

I think you can just remove this altogether and add a .romfile = "..."
entry instead like it is done for the other nics.

cheers,
  Gerd

  parent reply	other threads:[~2012-01-09  9:15 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-08 11:55 [Qemu-devel] [PATCH] network: Added option to disable NIC option roms Gerhard Wiesinger
2012-01-08 16:40 ` Stefan Hajnoczi
2012-01-08 20:56   ` Gerhard Wiesinger
2012-01-09  8:06     ` Stefan Hajnoczi
2012-01-09  9:15 ` Gerd Hoffmann [this message]
2012-01-12  6:45   ` Gerhard Wiesinger
2012-01-12  7:58     ` Gerd Hoffmann
2012-01-25 21:08       ` Gerhard Wiesinger
  -- strict thread matches above, loose matches on Subject: below --
2012-01-25 21:01 Gerhard Wiesinger
2012-01-26  7:45 ` Markus Armbruster
2012-01-26 10:45   ` Gerd Hoffmann
2012-01-26 11:00     ` Markus Armbruster
2012-01-27  6:56       ` Gerhard Wiesinger
2012-01-27 16:02       ` Gerhard Wiesinger
2012-02-13  6:23         ` Gerhard Wiesinger
2012-02-16  6:41           ` Gerhard Wiesinger
2012-02-01 22:19     ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F0AB023.5040705@redhat.com \
    --to=kraxel@redhat.com \
    --cc=gleb@redhat.com \
    --cc=kevin@koconnor.net \
    --cc=lists@wiesinger.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).